Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RSDK-6194 rename arm64 release artifacts #87

Merged
merged 1 commit into from
Dec 27, 2023
Merged

Conversation

abe-winter
Copy link
Member

What changed

  • revert naming style of the aarch64 release artifact to the old style

Why

  • the name of this output changed between 0.1.2 and 0.1.3
  • viam-cpp-sdk consumes static rust-utils from github releases here in CMake
  • this causes some c++ modules to fail on arm (example CI failure here)

Other approaches

  • if the new format is the superior format we can edit the URL in the cpp sdk instead

@abe-winter abe-winter requested a review from a team as a code owner December 27, 2023 19:04
@abe-winter abe-winter requested review from njooma and removed request for a team December 27, 2023 19:04
Copy link
Member

@benjirewis benjirewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, no aarch64-unknown-linux-gnu is not a purposefully different format; I wasn't aware that I had even changed the naming. Thanks for catching this!

@abe-winter abe-winter merged commit a810ed2 into main Dec 27, 2023
6 checks passed
@abe-winter abe-winter deleted the arm-output-name branch December 27, 2023 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants