RSDK-9300 - make mdns query more generic over local-ness of candidate #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuqdog
commented
Jan 24, 2025
| @@ -400,7 +403,7 @@ impl<T: AuthMethod> DialBuilder<T> { | |||
|
|
|||
| let ifaces: HashMap<&str, Vec<&IpAddr>> = | |||
| ifaces.iter().fold(HashMap::new(), |mut map, (k, v)| { | |||
| map.entry(k).or_insert(vec![]).push(v); | |||
| map.entry(k).or_default().push(v); | |||
stuqdog
commented
Jan 24, 2025
| let discovery = discover::interface_with_loopback( | ||
| addr_to_send, | ||
| VIAM_MDNS_SERVICE_NAME, |
There was a problem hiding this comment.
See added comment re: the localness of machine URIs to understand why this is important. Basically, we were trying to discover candidates with a fully qualified name. but, the fully qualified name we were passing was non-local and, for reasons not entirely clear to me, the only candidates we could find from a micro-rdk process were the ones with a local name. By making our search more generic we can find everything that looks Viam-y, and then narrow it down based on the actual name of the machine.
njooma
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue where
rust-utilswas unable to find an mDNS candidate for micro-rdk robots.Tested locally: before change, was unable to connect to a native micro-rdk process with signaling disabled. After change, I was able to connect to the same micro-rdk process whether signaling was enabled or not. Also tested to ensure no regression in connectivity to a locally running
viam-serverprocess, both with wifi on and with wifi off.cc @acmorrow