Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DATA-3192: Change collector default queue size to 0 #4663

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

DATA-3192: Change collector default queue size to 0 #4663

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 2 additions & 7 deletions services/datamanager/builtin/capture/capture.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,14 +21,9 @@ import (
"go.viam.com/rdk/services/datamanager"
)

// TODO: re-determine if queue size is optimal given we now support 10khz+ capture rates
// The Collector's queue should be big enough to ensure that .capture() is never blocked by the queue being
// written to disk. A default value of 250 was chosen because even with the fastest reasonable capture interval (1ms),
// this would leave 250ms for a (buffered) disk write before blocking, which seems sufficient for the size of
// writes this would be performing.
const defaultCaptureQueueSize = 250

const (
// Default channel size for collector's capture results.
defaultCaptureQueueSize = 0
// Default bufio.Writer buffer size in bytes.
defaultCaptureBufferSize = 4096
defaultMongoDatabaseName = "sensorData"
Expand Down
Loading