fix(services/vision/ml_model): add err to errList when build attempt fails #4659
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on a new MLModel service module, I ran into an issue testing it with vision/mlmodel module where the vision module would panic due to indexing a list out of bounds:
I traced the source of the error to the vision's Reconfigure method, which expects an
errList
variable to have at least 3 values for each attempt at building a different type of vision service (classifier, detector, 3D segmenter). This logic only works if the first checks ofattemptToBuildClassifier
andattemptToBuildDetector
don't error, which was happening with my in-progress module. I've resolved this by appending the result errors from those checks to theerrList
to maintain the expected length.