-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: release with pnpm publish
instead of action
#48
Conversation
837e529
to
edffb31
Compare
edffb31
to
5a83a43
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not the most familiar with this workflow, so going to allow others to approve
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
projectService
is neat. Thanks for doing this!
package: ./packages/typescript-config | ||
token: ${{ secrets.NPM_TOKEN }} | ||
- name: 'Publish 🚀' | ||
run: pnpm publish --recursive |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😎
Overview
This stack of PRs updates our common JS configs over to their
1.0.0
versions. The main difference between the versions so far andv1
is that (thanks to the ESLint v9 update) the various plugins and configs that we stitch together will be pulled in automatically asdependencies
- simplifying setup by removing most required peer dependencies.pnpm publish
instead of action #48Change log
This PR gets ready for this change by:
pnpm publish --recursive
, allowing us to useworkspace
dependencies properly across projectsReview requests
Nothing in particular here as long as CI is green