Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: release with pnpm publish instead of action #48

Merged
merged 4 commits into from
Dec 2, 2024

Conversation

mcous
Copy link
Member

@mcous mcous commented Nov 27, 2024

Overview

This stack of PRs updates our common JS configs over to their 1.0.0 versions. The main difference between the versions so far and v1 is that (thanks to the ESLint v9 update) the various plugins and configs that we stitch together will be pulled in automatically as dependencies - simplifying setup by removing most required peer dependencies.

  1. 🌿 ci: release with pnpm publish instead of action #48
  2. feat(prettier-config)!: split configs and use direct dependencies #49
  3. feat(eslint-config)!: split config packages #50
  4. TODO: Update ESLint packages to use ESLint v9 and flat configs

Change log

This PR gets ready for this change by:

  • Switching the publish job to pnpm publish --recursive, allowing us to use workspace dependencies properly across projects
  • Switching our TSConfig to use project references, for the same reason
  • Updating deps to avoid cluttering future PRs

Review requests

Nothing in particular here as long as CI is green

Copy link
Member

@ehhong ehhong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not the most familiar with this workflow, so going to allow others to approve

package.json Show resolved Hide resolved
Copy link

@zaporter zaporter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

projectService is neat. Thanks for doing this!

package.json Outdated Show resolved Hide resolved
@mcous mcous merged commit 667e8e9 into main Dec 2, 2024
3 checks passed
@mcous mcous deleted the ci/switch-to-pnpm-publish branch December 2, 2024 22:04
package: ./packages/typescript-config
token: ${{ secrets.NPM_TOKEN }}
- name: 'Publish 🚀'
run: pnpm publish --recursive
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants