DATA-2153 - Change TabularDataByQuery API to accept list of BSON docs rather than strings #400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agreenb
reviewed
Nov 28, 2023
| string mql_query = 2; | ||
| // mql_binary accepts a MongoDB aggregation pipeline as a list of BSON documents, where each |
There was a problem hiding this comment.
[nit] list of serialized BSON documents?
There was a problem hiding this comment.
I think simply saying "BSON documents" is actually more accurate, since BSON is already in a binary/byte format - a BSON document is just a series of bytes with a particular format. You can serialize/encode objects into BSON, but saying "serialized BSON documents" to me makes it sound like we took BSON documents and serialized/encoded them further. Lmk if you disagree!
agreenb
approved these changes
Nov 28, 2023
agreenb
approved these changes
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.