-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[APP-2783]: (API) Simplify shared location permissions #392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* upstream/main: DATA-1976 - Add DeleteCompletedTrainingJob to API (#387)
maxhorowitz
changed the title
[APP-2783]: Simplify shared location permissions
[APP-2783]: (API) Simplify shared location permissions
Nov 5, 2023
maxhorowitz
force-pushed
the
app-2783
branch
2 times, most recently
from
December 4, 2023 18:56
ef05ed5
to
6e28bb9
Compare
ohEmily
approved these changes
Dec 5, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
proto/viam/app/v1/app.proto
changes LGTM.
RoxyFarhad
added
bug
Something isn't working
and removed
bug
Something isn't working
labels
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a branch containing the API changes required in the Simplify shared location permissions project. Reference this PR's temp environment for the entire project. Only addition is to the
AppService
definition (proto/viam/app/v1/app.proto
).