Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APP-2783]: (API) Simplify shared location permissions #392

Merged
merged 15 commits into from
Dec 5, 2023
Merged

Conversation

maxhorowitz
Copy link
Member

@maxhorowitz maxhorowitz commented Oct 31, 2023

This is a branch containing the API changes required in the Simplify shared location permissions project. Reference this PR's temp environment for the entire project. Only addition is to the AppService definition (proto/viam/app/v1/app.proto).

@maxhorowitz maxhorowitz marked this pull request as ready for review October 31, 2023 17:38
@maxhorowitz maxhorowitz changed the title [APP-2783]: Simplify shared location permissions [APP-2783]: (API) Simplify shared location permissions Nov 5, 2023
@maxhorowitz maxhorowitz force-pushed the app-2783 branch 2 times, most recently from ef05ed5 to 6e28bb9 Compare December 4, 2023 18:56
Copy link
Member

@ohEmily ohEmily left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

proto/viam/app/v1/app.proto changes LGTM.

@RoxyFarhad RoxyFarhad added bug Something isn't working and removed bug Something isn't working labels Dec 5, 2023
@maxhorowitz maxhorowitz merged commit fa63ec9 into main Dec 5, 2023
4 checks passed
@maxhorowitz maxhorowitz deleted the app-2783 branch December 5, 2023 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants