feat: add local speech provider support #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HipsterBrown
commented
Mar 29, 2024
| @@ -322,6 +333,7 @@ def reconfigure( | |||
| str(attrs.get("speech_provider", "google")) | |||
| ] | |||
| self.speech_provider_key = str(attrs.get("speech_provider_key", "")) | |||
| self.speech_service_name = str(attrs.get("speech_service_name", "")) | |||
There was a problem hiding this comment.
I went with this approach of the "local" value for the speech provider field paired with this field to keep the Enum usage for the SpeechProvider. If we want this configuration to match the listen_provider setting just the service name, I can refactor for consistency and remove the Enum.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This cannot be merged until the RDK modules manager supports foreign server handlers for module <-> module gRPC communication.
In order to support other speech-to-text (STT) capabilities with this module, this PR adds the
"local"option to thespeech_providerconfiguration attribute and associatedspeech_service_nameattribute.