Fixed same root rename bug

viaduct-ai · Dec 4, 2019 · 47147a2 · 47147a2
1 parent 83a4f61
commit 47147a2
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 0 deletions.
diff --git a/hybridcontents/hybridmanager.py b/hybridcontents/hybridmanager.py
@@ -321,4 +321,6 @@ def rename(self, old_path, new_path):
         # Else we are moving within a single ContentManager
         assert new_prefix == old_prefix
 
+        self._validate_path(new_prefix, new_mgr_path)
+
         return new_mgr.rename(old_mgr_path, new_mgr_path)
diff --git a/hybridcontents/tests/test_hybrid_manager.py b/hybridcontents/tests/test_hybrid_manager.py
@@ -326,6 +326,17 @@ def test_rename_invalid_path(self):
         with assertRaisesHTTPError(self, 405):
             cm.rename(old_path, new_path)
 
+    def test_rename_invalid_path_same_manager(self):
+        cm = self.contents_manager
+
+        cm.new_untitled(path='A', ext='.txt')
+
+        old_path = 'A/Untitled.txt'
+        new_path = 'A/Untitled2.yaml'
+
+        with assertRaisesHTTPError(self, 405):
+            cm.rename(old_path, new_path)
+
     def test_save_invalid_path(self):
         cm = self.contents_manager