Make the default surjection max_anchors unlimited #4338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamnovak
force-pushed
the
unlimited-anchors
branch
from
c50ecd4 to
15c38d7
Compare
|
@jeizenga When you were looking at lifting the anchor limit and changed the default in the header, were you testing with Giraffe-integrated surjection and not |
|
Honestly, I didn't really plan to test these changes, but I think it makes sense to raise the limit in both. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Entry
To be copied to the draft changelog by merger:
vg surjectnow uses an unlimited--max-anchorsby defaultDescription
This should fix #4336 and make the defaults make more sense for long reads.