Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin back Requests to make sure Python Docker API works #4300

Merged
merged 1 commit into from
May 22, 2024
Merged

Pin back Requests to make sure Python Docker API works #4300

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions vgci/vgci.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -340,12 +340,14 @@ then

# Dependencies for running tests. Need numpy, scipy and sklearn for
# running toil-vg mapeval, and dateutils and reqests for
# ./mins_since_last_build.py. Make sure to get the giant buildable modules
# as binaries only to avoid wasting CI time building some slightly nicer
# version Pip prefers.
pip3 install pytest timeout_decorator requests dateutils
# ./mins_since_last_build.py. Need exactly the right version of requests
# for the Python Docker API to work (see
# <https://github.com/docker/docker-py/issues/3256>).
pip3 install pytest timeout_decorator 'requests==2.31.0' dateutils
# TODO: To upgrade to Numpy 1.24+, we need to remove usages of `numpy.int`
# AKA `np.int` from toil-vg. See <https://stackoverflow.com/a/74946903>
# Make sure to get the giant buildable modules as binaries only to avoid
# wasting CI time building some slightly nicer version Pip prefers.
pip3 install 'numpy==1.23.5' scipy scikit-learn --only-binary :all:

# Install Toil
Expand Down
Loading