Airtanks & Batteries #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -202,7 +202,7 @@ public static class Atmospherics | |||
| /// <summary> | |||
| /// This is calculated to help prevent singlecap bombs (Overpowered tritium/oxygen single tank bombs) | |||
| /// </summary> | |||
| public const float MinimumTritiumOxyburnEnergy = 143000f; | |||
| public const float MinimumTritiumOxyburnEnergy = 429000f; | |||
There was a problem hiding this comment.
sneakycode to make bombs more powerful?
There was a problem hiding this comment.
Apparently that is correlated to the volume of the container or something, and there was a comment specifically to adjust that when adjusting tank volumes
Eneocho
added
Tweak
|
y'all gotta upstream this fr |
As in, you want EE main to have these as well? |
|
Going to merge this now but we will need to fix the tests later. |
spess-empyrean
merged commit 47dc053
into
vgstation-coders:master
9 of 10 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Real Gas Laws and Thermodynamics when????
Description
Emergency air tanks don't last long enough. Flashlights don't last long enough. Flashlights break when left on for too long and replacing their power cell doesn't fix them. Power dies on the station in as little as five minutes.
Now they work.
Tested on multiple maps, changes to the SMES, SS and APCs result in uninterrupted power for around 15 minutes before the Substations for Science and Medical start to fail, putting them on a APC power for a few minutes before going dark.
Emergency air tanks and tanks in general last longer. Emergency tanks start will a full capacity.
Flashlights last 8x longer and shut off without dimming or flashing when empty. They now work normally after replacing the cell.
The blinking fix was lazy after a few hours of not having any success in resetting the animation system. Instead I just commented it all out. Now your brightness is binary.
Changelog
🆑