Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TestRtpStreamSend: ASAN, fix buffer overflow #1418

Closed
wants to merge 1 commit into from
Closed

TestRtpStreamSend: ASAN, fix buffer overflow #1418

wants to merge 1 commit into from

Conversation

jmillan
Copy link
Member

@jmillan jmillan commented Jul 1, 2024

ibc
ibc approved these changes Jul 1, 2024
View reviewed changes
Copy link
Member

@ibc ibc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you think it's relevant, can you explain the fix? Also, I am on mobile now and cannot see which exact comment in the issue it points to. Can you specify with TODO comment number this PR fixes?

@jmillan jmillan requested a review from ibc July 1, 2024 14:06
@jmillan
Copy link
Member Author

jmillan commented Jul 1, 2024

Closing, I'm creating a new PR with a proper fix.

@jmillan jmillan closed this Jul 1, 2024
@jmillan jmillan deleted the testrtpstreamsend_fix_buffer_overflow branch July 1, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ibc ibc ibc approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AddressSanitizer issues
2 participants
@jmillan @ibc