fix asan error for new-delete-type-mismatch #1411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmillan
requested changes
Jun 19, 2024
Nope, it's err = uv_shutdown(
req, reinterpret_cast<uv_stream_t*>(this->uvHandle), static_cast<uv_shutdown_cb>(onShutdown));In .hpp: uv_pipe_t* uvHandle{ nullptr };So PR is ok IMHO. |
I verified that If ASAN is not complaining then 👍 |
jmillan
approved these changes
Jun 19, 2024
uv_pipe is a subtype of uv_stream. uv_tcp as well. |
|
Let's not merge yet, I want to check something. |
|
It's ok. Merging. Thanks @satoren. But the same should be done in |
ibc
added a commit
that referenced
this pull request
Jun 19, 2024
This is the same change as done in PR #1411 but here in `TcpConnectionHandle.cpp`.
dhilipsiva
added a commit
to ds-forks/mediasoup
that referenced
this pull request
Jun 22, 2024
* v3: chore: Update Rust toolchain channel to version 1.79.0 Fix issue versatica#1374 cosmetic fix Simulcast IncreaseLayer bug when producer score is zero (versatica#1410) Update NPM deps TcpConnectionHandle.cpp: properly close handle fix asan error for new-delete-type-mismatch (versatica#1411)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This handle seems to be of type
uv_pipe_t.