Fix Worker crash when closing WebRtcServer with active WebRtcTransports #1390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #1388 ### Details - `WebRtcServer` destructor must first close its `WebRtcTransports` and then the UDP sockets and TCP servers (so also its TCP connections). Otherwise those `WebRtcTransports` will try to send DTLS Close Alert on an already closed/freed `UdpSocketHandle` or `TcpConnectionHandle`. ### Steps to verify 1. Have `WebRtcServer` running and a client connected. 2. In server side call `webRtcServer.close()`. 3. It should not crash anymore.
jmillan
approved these changes
May 3, 2024
jmillan
deleted the
fix-worker-crash-when-closing-webrtcserver-with-active-connections
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1388
Details
WebRtcServerdestructor must first close itsWebRtcTransportsand then the UDP sockets and TCP servers (so also its TCP connections). Otherwise thoseWebRtcTransportswill try to send DTLS Close Alert on an already closed/freedUdpSocketHandleorTcpConnectionHandle.Steps to verify
WebRtcServerrunning and a client connected.webRtcServer.close().