Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Add macos-14 #1328

Merged
merged 3 commits into from
Feb 5, 2024
Merged

CI: Add macos-14 #1328

merged 3 commits into from
Feb 5, 2024

Conversation

ibc
Copy link
Member

@ibc ibc commented Feb 5, 2024

As per GH announcement: https://github.blog/changelog/2024-01-30-github-actions-introducing-the-new-m1-macos-runner-available-to-open-source/

Also remove the NPM 'release:upload-mac-arm-prebuilt-worker' since it's no longer needed.

@ibc ibc requested review from jmillan and nazar-pc February 5, 2024 10:12
Copy link
Collaborator

@nazar-pc nazar-pc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd also remove macos-12, but up to you

@ibc
Copy link
Member Author

ibc commented Feb 5, 2024

I'd also remove macos-12, but up to you

Let's keep it for a while. Let's at least test latest 2 versions.

@ibc
Copy link
Member Author

ibc commented Feb 5, 2024

TODO: If this works we should remove the uploadMacArmPrebuiltWorker() stuff in npm-scripts since it's no longer needed. But I'll do it later once we verify that.

UPDATE: No, I'll do it now.

@ibc ibc merged commit c621b29 into v3 Feb 5, 2024
22 checks passed
@ibc ibc deleted the ci-add-macos-14 branch February 5, 2024 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants