Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup remaining payload channel references #1326

Merged
merged 2 commits into from
Feb 5, 2024
Merged

Conversation

jmillan
Copy link
Member

@jmillan jmillan commented Feb 2, 2024

No description provided.

Copy link
Collaborator

@nazar-pc nazar-pc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will require minor version bump for mediasoup-sys due to change in public API

@ibc
Copy link
Member

ibc commented Feb 2, 2024

Rationale please?

@nazar-pc
Copy link
Collaborator

nazar-pc commented Feb 2, 2024

Cargo will be happy to install compatible (according to semver) version of the package that is newer than technically required. Since arguments changed, older mediasoup will no longer be compatible with newer mediasoup-sys. So instead of increasing patch version we have to increase minor version to prevent breaking changes for people.

@jmillan
Copy link
Member Author

jmillan commented Feb 5, 2024

It can be merged since the minor version has been increased here #1324

@jmillan jmillan merged commit 5775aff into v3 Feb 5, 2024
20 checks passed
@jmillan jmillan deleted the payloadchannel-cleanup branch February 5, 2024 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants