Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

C++: tidy up #1304

Merged
merged 5 commits into from
Jan 8, 2024
Merged

C++: tidy up #1304

merged 5 commits into from
Jan 8, 2024

Conversation

jmillan
Copy link
Member

@jmillan jmillan commented Jan 8, 2024

No description provided.

ibc
ibc reviewed Jan 8, 2024
View reviewed changes
Copy link
Member

@ibc ibc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you comment a bit about how to use this? In which environment does it work? Only in Linux/Docker? Requirements? Do we have to install deps at global level or something? If so, which versions?

worker/include/RTC/PlainTransport.hpp Outdated Show resolved Hide resolved
jmillan
jmillan commented Jan 8, 2024
View reviewed changes
worker/src/RTC/PortManager.cpp Outdated Show resolved Hide resolved
worker/src/RTC/RtpRetransmissionBuffer.cpp Show resolved Hide resolved
worker/src/RTC/SctpAssociation.cpp Outdated Show resolved Hide resolved
worker/src/RTC/WebRtcServer.cpp Show resolved Hide resolved
@ibc
Copy link
Member

ibc commented Jan 8, 2024

CI failing

@jmillan
Copy link
Member Author

jmillan commented Jan 8, 2024 •
edited
Loading

Can you comment a bit about how to use this? In which environment does it work? Only in Linux/Docker? Requirements? Do we have to install deps at global level or something? If so, which versions?

These are just code changes. The lint command is not YET uploaded, and even code changes have not finished. I'm doing those in different PRs. I'm going step by step. This is not as automated as it seems yet.

@ibc
Copy link
Member

ibc commented Jan 8, 2024

These are just code changes. The lint command is not YET be uploaded, and even code changes have not finished. I'm doing those in different PRs. I'm going step by step. This is not as automated as it seems yet.

Ok, so what is the command to make these errors show up? invoke tify?

@jmillan
Copy link
Member Author

jmillan commented Jan 8, 2024

Ok, so what is the command to make these errors show up? invoke tify?

Yes, yes, how we call tidy will not change.

@jmillan
Copy link
Member Author

jmillan commented Jan 8, 2024

@ibc, CI passing and ready to merge. Let me know if you have any concern so I'll continue with the next PR.

@ibc
Copy link
Member

ibc commented Jan 8, 2024

Approved.

@jmillan jmillan merged commit 6a573c2 into v3 Jan 8, 2024
20 checks passed
@jmillan jmillan deleted the clang-tidy branch January 8, 2024 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ibc ibc ibc approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jmillan @ibc