Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Node tests independent (part 1) #1295

Merged
merged 1 commit into from
Jan 4, 2024
Merged

Conversation

ibc
Copy link
Member

@ibc ibc commented Jan 4, 2024

Details

  • Make each test() independent of other tests in same file. The goal is that a failing test doesn't make other tests also fail.
  • For now just done in test-Worker.ts as a POC.
  • Rename node/src/tests/ to node/src/test/ for consistency and convention.
  • Make it possible to pass Jest command line args to npm run test:node script.

### Details

- Make each `test()` independent of other tests in same file. The goal is that a failing test doesn't make other tests also fail.
- For now just done in `test-Worker.ts` as a POC.
- Rename `node/src/tests/` to `node/src/test/` for consistency and convention.
- Make it possible to pass Jest command line args to `npm run test:node` script.
@ibc ibc requested review from jmillan and nazar-pc January 4, 2024 10:16
@ibc ibc merged commit 71d8c11 into v3 Jan 4, 2024
20 checks passed
@ibc ibc deleted the make-node-tests-independent-part-1 branch January 4, 2024 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants