Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements in CI files #1281

Merged
merged 7 commits into from
Dec 29, 2023
Merged
Show file tree
Hide file tree
Changes from 5 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 10 additions & 11 deletions .github/workflows/codeql.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -9,16 +9,15 @@
# the `language` matrix defined below to confirm you have the correct set of
# supported CodeQL languages.
#
name: "CodeQL"
name: CodeQL

on:
push:
branches: [ "v3" ]
pull_request:
# The branches below must be a subset of the branches above
branches: [ "v3" ]
schedule:
- cron: '37 9 * * 5'
on: [push, pull_request]

concurrency:
# Cancel a currently running workflow from the same PR, branch or tag when a
# new workflow is triggered.
group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }}
cancel-in-progress: true

jobs:
analyze:
Expand All @@ -32,8 +31,8 @@ jobs:
strategy:
fail-fast: false
matrix:
language: [ 'cpp', 'javascript', 'python' ]
# CodeQL supports [ 'cpp', 'csharp', 'go', 'java', 'javascript', 'python', 'ruby' ]
language: [ "cpp", "javascript", "python" ]
# CodeQL supports [ "cpp", "csharp", "go", "java", "javascript", "python", "ruby" ]
# Learn more about CodeQL language support at https://aka.ms/codeql-docs/language-support

env:
Expand Down
5 changes: 3 additions & 2 deletions .github/workflows/mediasoup-node.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ jobs:
ci:
strategy:
matrix:
fail-fast: true
ibc marked this conversation as resolved.
Show resolved Hide resolved
ci:
- os: ubuntu-20.04
node: 16
Expand All @@ -27,7 +28,7 @@ jobs:
runs-on: ${{ matrix.ci.os }}

env:
MEDIASOUP_SKIP_WORKER_PREBUILT_DOWNLOAD: 'true'
MEDIASOUP_SKIP_WORKER_PREBUILT_DOWNLOAD: "true"

steps:
- name: Checkout
Expand All @@ -43,7 +44,7 @@ jobs:
with:
path: |
~/.npm
key: ${{ matrix.ci.os }}-node-${{ hashFiles('**/package.json') }}
key: ${{ matrix.ci.os }}-node-${{ hashFiles("**/package.json") }}
restore-keys: |
${{ matrix.ci.os }}-node-

Expand Down
9 changes: 5 additions & 4 deletions .github/workflows/mediasoup-rust.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ env:
jobs:
ci:
strategy:
fail-fast: true
matrix:
os:
- ubuntu-20.04
Expand All @@ -24,7 +25,7 @@ jobs:
runs-on: ${{ matrix.os }}

env:
KEEP_BUILD_ARTIFACTS: '1'
KEEP_BUILD_ARTIFACTS: "1"

steps:
- name: Checkout
Expand All @@ -36,7 +37,7 @@ jobs:
path: |
~/.cargo/registry
~/.cargo/git
key: ${{ matrix.os }}-cargo-${{ hashFiles('**/Cargo.toml') }}
key: ${{ matrix.os }}-cargo-${{ hashFiles("**/Cargo.toml") }}

- name: cargo fmt
run: cargo fmt --all -- --check
Expand All @@ -50,6 +51,6 @@ jobs:
- name: cargo doc
run: cargo doc --locked --all --no-deps --lib
env:
DOCS_RS: '1'
RUSTDOCFLAGS: '-D rustdoc::broken-intra-doc-links -D rustdoc::private_intra_doc_links'
DOCS_RS: "1"
RUSTDOCFLAGS: "-D rustdoc::broken-intra-doc-links -D rustdoc::private_intra_doc_links"

2 changes: 1 addition & 1 deletion .github/workflows/mediasoup-worker-prebuild.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ on:
jobs:
ci:
strategy:
fail-fast: false
fail-fast: true
matrix:
build:
# For Linux let's use an old version of Ubuntu (20.04) that builds the
Expand Down
12 changes: 6 additions & 6 deletions .github/workflows/mediasoup-worker.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ concurrency:
jobs:
ci:
strategy:
fail-fast: false
fail-fast: true
matrix:
build:
- os: ubuntu-20.04
Expand Down Expand Up @@ -44,7 +44,7 @@ jobs:
env:
CC: ${{ matrix.build.cc }}
CXX: ${{ matrix.build.cxx }}
MEDIASOUP_SKIP_WORKER_PREBUILT_DOWNLOAD: 'true'
MEDIASOUP_SKIP_WORKER_PREBUILT_DOWNLOAD: "true"

steps:
- name: Checkout
Expand All @@ -60,7 +60,7 @@ jobs:
with:
path: |
~/.npm
key: ${{ matrix.build.os }}-node-${{matrix.build.cc}}-${{ hashFiles('**/package.json') }}
key: ${{ matrix.build.os }}-node-${{matrix.build.cc}}-${{ hashFiles("**/package.json") }}
restore-keys: |
${{ matrix.build.os }}-node-${{matrix.build.cc}}-

Expand All @@ -72,17 +72,17 @@ jobs:
- name: npm ci --prefix worker/scripts
run: npm ci --prefix worker/scripts --foreground-scripts
# TODO: Maybe fix this one day.
if: runner.os != 'Windows'
if: runner.os != "Windows"

- name: invoke -r worker lint
run: invoke -r worker lint
# TODO: Maybe fix this one day.
if: runner.os != 'Windows'
if: runner.os != "Windows"

- name: invoke -r worker mediasoup-worker
run: invoke -r worker mediasoup-worker

- name: invoke -r worker test
run: invoke -r worker test
# TODO: Maybe fix this one day.
if: runner.os != 'Windows'
if: runner.os != "Windows"
18 changes: 0 additions & 18 deletions .github/workflows/pull-request-stats.yml

This file was deleted.

Loading