-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sender report trace event #1267
Conversation
92bccd2
to
e6b9762
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good but Rust changes are also required.
Not familiar with rust so I am relying on the videoroom example for manual testing, hope it is enough. |
Just do |
Run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good so far 👍, just a cosmetic naming change requested.
Changelog entry missing and this must be documented in the website (I'll do). |
@@ -1234,3 +1236,34 @@ impl BweTraceInfo { | |||
} | |||
} | |||
} | |||
|
|||
/// BWE info in trace event. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not "BWE info".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll merge and make this change in v3.
Thank you |
This PR adds a trace event for incoming RTCP sender reports from producers, to provide timestamp information in the node API. Covers use cases of server-side stream synchronization (like recording).
Usage
producer.enableTraceEvent(['sr'])
emits
Resolves issue #1248