Add a test to check issue #1366 and use Debug mode

versatica · Apr 8, 2024 · f931062 · f931062
1 parent 1a507ec
commit f931062
Show file tree

Hide file tree

Showing 2 changed files with 37 additions and 0 deletions.
diff --git a/.github/workflows/mediasoup-worker.yaml b/.github/workflows/mediasoup-worker.yaml
@@ -108,3 +108,8 @@ jobs:
         run: invoke -r worker test
         # TODO: Maybe fix this one day.
         if: runner.os != 'Windows'
+
+      - name: MEDIASOUP_BUILDTYPE=Debug invoke -r worker test
+        run: MEDIASOUP_BUILDTYPE=Debug invoke -r worker test
+        # TODO: Maybe fix this one day.
+        if: runner.os != 'Windows'
diff --git a/worker/test/src/RTC/TestNackGenerator.cpp b/worker/test/src/RTC/TestNackGenerator.cpp
@@ -139,6 +139,38 @@ void validate(std::vector<TestNackGeneratorInput>& inputs)
 	}
 };
 
+SCENARIO("ISSUE 1366: https://github.com/versatica/mediasoup/issues/1366")
+{
+	SECTION("absl::btree_set")
+	{
+		REQUIRE(RTC::SeqManager<uint16_t>::IsSeqLowerThan(10000, 40000) == true);
+		REQUIRE(RTC::SeqManager<uint16_t>::IsSeqLowerThan(40000, 60000) == true);
+		REQUIRE(RTC::SeqManager<uint16_t>::IsSeqLowerThan(10000, 60000) == false);
+	}
+
+	SECTION("std::set")
+	{
+		std::set<uint16_t, RTC::SeqManager<uint16_t>::SeqLowerThan> recoveredList;
+
+		recoveredList.insert(10000);
+		recoveredList.insert(40000);
+		recoveredList.insert(60000);
+
+		REQUIRE(recoveredList.size() == 3);
+	}
+
+	// SECTION("absl::btree_set")
+	// {
+	// 	absl::btree_set<uint16_t, RTC::SeqManager<uint16_t>::SeqLowerThan> recoveredList;
+
+	// 	recoveredList.insert(10000);
+	// 	recoveredList.insert(40000);
+	// 	recoveredList.insert(60000);
+
+	// 	REQUIRE(recoveredList.size() == 3);
+	// }
+}
+
 SCENARIO("NACK generator", "[rtp][rtcp]")
 {
 	SECTION("no NACKs required")