SimpleConsumer: Opus DTX ignore capabilities (#846)

* SimpleConsumer: Opus DTX ignore capabilities
versatica · Jun 29, 2022 · f6d1284 · f6d1284
1 parent a4c7fec
commit f6d1284
Show file tree

Hide file tree

Showing 18 changed files with 272 additions and 14 deletions.
diff --git a/node/lib/Consumer.d.ts b/node/lib/Consumer.d.ts
@@ -38,6 +38,11 @@ export declare type ConsumerOptions = {
      * If unset, the highest ones are selected.
      */
     preferredLayers?: ConsumerLayers;
+    /**
+     * Whether this Consumer should ignore DTX packets (only valid for Opus codec).
+     * If set, DTX packets are not forwarded to the remote Consumer.
+     */
+    ignoreDtx?: Boolean;
     /**
      * Whether this Consumer should consume all RTP streams generated by the
      * Producer.

diff --git a/node/lib/Consumer.d.ts.map b/node/lib/Consumer.d.ts.map
diff --git a/node/lib/Transport.d.ts b/node/lib/Transport.d.ts
@@ -176,7 +176,7 @@ export declare class Transport<Events extends TransportEvents = TransportEvents,
      *
      * @virtual
      */
-    consume({ producerId, rtpCapabilities, paused, mid, preferredLayers, pipe, appData }: ConsumerOptions): Promise<Consumer>;
+    consume({ producerId, rtpCapabilities, paused, mid, preferredLayers, ignoreDtx, pipe, appData }: ConsumerOptions): Promise<Consumer>;
     /**
      * Create a DataProducer.
      */

diff --git a/node/lib/Transport.d.ts.map b/node/lib/Transport.d.ts.map
diff --git a/node/lib/Transport.js b/node/lib/Transport.js
@@ -345,7 +345,7 @@ class Transport extends EnhancedEventEmitter_1.EnhancedEventEmitter {
      *
      * @virtual
      */
-    async consume({ producerId, rtpCapabilities, paused = false, mid, preferredLayers, pipe = false, appData }) {
+    async consume({ producerId, rtpCapabilities, paused = false, mid, preferredLayers, ignoreDtx = false, pipe = false, appData }) {
         logger.debug('consume()');
         if (!producerId || typeof producerId !== 'string')
             throw new TypeError('missing producerId');
@@ -381,7 +381,8 @@ class Transport extends EnhancedEventEmitter_1.EnhancedEventEmitter {
             type: pipe ? 'pipe' : producer.type,
             consumableRtpEncodings: producer.consumableRtpParameters.encodings,
             paused,
-            preferredLayers
+            preferredLayers,
+            ignoreDtx
         };
         const status = await this.channel.request('transport.consume', internal, reqData);
         const data = {

diff --git a/node/lib/types.js b/node/lib/types.js
@@ -1,11 +1,7 @@
 "use strict";
 var __createBinding = (this && this.__createBinding) || (Object.create ? (function(o, m, k, k2) {
     if (k2 === undefined) k2 = k;
-    var desc = Object.getOwnPropertyDescriptor(m, k);
-    if (!desc || ("get" in desc ? !m.__esModule : desc.writable || desc.configurable)) {
-      desc = { enumerable: true, get: function() { return m[k]; } };
-    }
-    Object.defineProperty(o, k2, desc);
+    Object.defineProperty(o, k2, { enumerable: true, get: function() { return m[k]; } });
 }) : (function(o, m, k, k2) {
     if (k2 === undefined) k2 = k;
     o[k2] = m[k];

diff --git a/node/src/Consumer.ts b/node/src/Consumer.ts
@@ -49,6 +49,12 @@ export type ConsumerOptions =
 	 */
 	preferredLayers?: ConsumerLayers;
 
+	/**
+	 * Whether this Consumer should ignore DTX packets (only valid for Opus codec).
+	 * If set, DTX packets are not forwarded to the remote Consumer.
+	 */
+	ignoreDtx?: Boolean;
+
 	/**
 	 * Whether this Consumer should consume all RTP streams generated by the
 	 * Producer.