Skip to content

Commit

Permalink
Emit Router's observer 'newtransport' event before WebRtcServer's obs…
Browse files Browse the repository at this point in the history
…erver 'webrtctransporthandled' (#1138)
  • Loading branch information
piranna authored Aug 9, 2023
1 parent 54698cf commit df1f224
Showing 1 changed file with 6 additions and 6 deletions.
12 changes: 6 additions & 6 deletions node/src/Router.ts
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ type PipeTransportPair =
};

export type RouterEvents =
{
{
workerclose: [];
// Private events.
'@close': [];
Expand Down Expand Up @@ -465,14 +465,14 @@ export class Router<RouterAppData extends AppData = AppData>
this.#dataProducers.delete(dataProducer.id)
));

// Emit observer event.
this.#observer.safeEmit('newtransport', transport);

if (webRtcServer)
{
webRtcServer.handleWebRtcTransport(transport);
}

// Emit observer event.
this.#observer.safeEmit('newtransport', transport);

return transport;
}

Expand Down Expand Up @@ -1080,7 +1080,7 @@ export class Router<RouterAppData extends AppData = AppData>
{
throw new TypeError('if given, appData must be an object');
}

const reqData =
{
rtpObserverId : uuidv4(),
Expand All @@ -1103,7 +1103,7 @@ export class Router<RouterAppData extends AppData = AppData>
this.#producers.get(producerId)
)
});

this.#rtpObservers.set(activeSpeakerObserver.id, activeSpeakerObserver);
activeSpeakerObserver.on('@close', () =>
{
Expand Down

0 comments on commit df1f224

Please sign in to comment.