Run 'worker clean-all' before every ASAN test

versatica · Jul 18, 2024 · 9c29719 · 9c29719
1 parent 89fa6c9
commit 9c29719
Show file tree

Hide file tree

Showing 2 changed files with 27 additions and 8 deletions.
diff --git a/.github/workflows/mediasoup-worker.yaml b/.github/workflows/mediasoup-worker.yaml
@@ -11,6 +11,7 @@ concurrency:
 jobs:
   ci:
     strategy:
+      # Here we want to see all errors, not just the first one.
       fail-fast: false
       matrix:
         build:
@@ -48,7 +49,7 @@ jobs:
       CC: ${{ matrix.build.cc }}
       CXX: ${{ matrix.build.cxx }}
       MEDIASOUP_SKIP_WORKER_PREBUILT_DOWNLOAD: 'true'
-      MEDIASOUP_LOCAL_DEV: 'true'
+      MEDIASOUP_LOCAL_DEV: 'false'
       MEDIASOUP_BUILDTYPE: ${{ matrix.build-type }}
 
     steps:
@@ -90,26 +91,44 @@ jobs:
         # TODO: Maybe fix this one day.
         if: runner.os != 'Windows'
 
-      # - name: invoke -r worker mediasoup-worker
-      #   run: invoke -r worker mediasoup-worker
+      - name: invoke -r worker mediasoup-worker
+        run: invoke -r worker mediasoup-worker
 
-      # - name: invoke -r worker test
-      #   run: invoke -r worker test
-      #   # TODO: Maybe fix this one day.
-      #   if: runner.os != 'Windows'
+      - name: invoke -r worker test
+        run: invoke -r worker test
+        # TODO: Maybe fix this one day.
+        if: runner.os != 'Windows'
+
+      # Let's clean everything before rebuilding worker tests with ASAN.
+      - name: invoke -r worker clean-all
+        run: invoke -r worker clean-all
+        # Address Sanitizer only works on Linux.
+        if: runner.os == 'Linux'
 
       - name: invoke -r worker test-asan-address
         run: invoke -r worker test-asan-address
         # Address Sanitizer only works on Linux.
         if: runner.os == 'Linux'
 
+      # Let's clean everything before rebuilding worker tests with ASAN.
+      - name: invoke -r worker clean-all
+        run: invoke -r worker clean-all
+        # Address Sanitizer only works on Linux.
+        if: runner.os == 'Linux'
+
       # TODO: Uncomment once https://github.com/versatica/mediasoup/issues/1417
       # is fixed.
       # - name: invoke -r worker test-asan-undefined
       #   run: invoke -r worker test-asan-undefined
       #   # Address Sanitizer only works on Linux.
       #   if: runner.os == 'Linux'
 
+      # Let's clean everything before rebuilding worker tests with ASAN.
+      - name: invoke -r worker clean-all
+        run: invoke -r worker clean-all
+        # Address Sanitizer only works on Linux.
+        if: runner.os == 'Linux'
+
       # TODO: Uncomment once https://github.com/versatica/mediasoup/issues/1417
       # is fixed.
       # - name: invoke -r worker test-asan-thread

diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -3,7 +3,7 @@
 ### NEXT
 
 - Worker: Test, fix buffer overflow ([PR #1419](https://github.com/versatica/mediasoup/pull/1419)).
-- Bump up Meson from 1.3.0 to 1.4.1.
+- Bump up Meson from 1.3.0 to 1.5.0 ([PR #1424](https://github.com/versatica/mediasoup/pull/1424)).
 
 ### 3.14.8