Improve StunPacket::Dump() and CheckAuthentication()

versatica · Feb 19, 2024 · 2c95e29 · 2c95e29
1 parent 9e4eac9
commit 2c95e29
Showing 1 changed file with 11 additions and 7 deletions.
diff --git a/worker/src/RTC/StunPacket.cpp b/worker/src/RTC/StunPacket.cpp
@@ -394,14 +394,11 @@ namespace RTC
 		}
 		MS_DUMP("  size: %zu bytes", this->size);
 
-		char transactionId[25];
+		auto transactionId1 = Utils::Byte::Get4Bytes(this->transactionId, 0);
+		auto transactionId2 = Utils::Byte::Get8Bytes(this->transactionId, 4);
 
-		for (int i{ 0 }; i < 12; ++i)
-		{
-			// NOTE: n must be 3 because snprintf adds a \0 after printed chars.
-			std::snprintf(transactionId + (i * 2), 3, "%.2x", this->transactionId[i]);
-		}
-		MS_DUMP("  transactionId: %s", transactionId);
+		MS_DUMP("  transactionId (first 4 bytes): %" PRIu32, transactionId1);
+		MS_DUMP("  transactionId (last 8 bytes): %" PRIu64, transactionId2);
 		if (this->errorCode != 0u)
 		{
 			MS_DUMP("  errorCode: %" PRIu16, this->errorCode);
@@ -543,6 +540,13 @@ namespace RTC
 
 				break;
 			}
+
+			default:
+			{
+				MS_WARN_TAG(ice, "unknown STUN class %" PRIu16 ", cannot authenticate", this->klass);
+
+				return Authentication::BAD_MESSAGE;
+			}
 		}
 
 		// If there is FINGERPRINT it must be discarded for MESSAGE-INTEGRITY