TODO: This should make the test fail but it doesn't

So for whatever reason, setting `webrtc_transport_options.enable_udp = false` is ignored. Such a `enable_udp: false` value is not sent through the channel but instead the worker receives `true`. Why?
versatica · Oct 19, 2023 · 1e46e35 · 1e46e35
1 parent b10af01
commit 1e46e35
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/rust/tests/integration/webrtc_transport.rs b/rust/tests/integration/webrtc_transport.rs
@@ -160,8 +160,8 @@ fn create_succeeds() {
                         .try_into()
                         .unwrap(),
                     );
-                    // TODO: I wonder how this was not needed before...
                     webrtc_transport_options.enable_sctp = true;
+                    webrtc_transport_options.enable_udp = false;
                     webrtc_transport_options.num_sctp_streams = NumSctpStreams {
                         os: 2048,
                         mis: 2048,

diff --git a/worker/src/RTC/WebRtcServer.cpp b/worker/src/RTC/WebRtcServer.cpp
@@ -268,6 +268,11 @@ namespace RTC
 		std::vector<RTC::IceCandidate> iceCandidates;
 		uint16_t iceLocalPreferenceDecrement{ 0 };
 
+		if (!enableUdp)
+			MS_DUMP_STD("---------------------- no enableUdp");
+		else
+			MS_DUMP_STD("---------------------- YES enableUdp");
+
 		for (auto& item : this->udpSocketOrTcpServers)
 		{
 			if (item.udpSocket && enableUdp)