Detect embedded webview on iPadOS. #280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iPadOS identifies as Mac OS, but ua-parser-js does the extra detection to determine if it's an iPad. Use the device model to detect when we're in an embedded webview on iPadOS. Also removes the version check for best effort webkit detection as iPadOS sends version 10.15 and checking RTCRtpTransceiver should be sufficient without the version check.
|
Debug log from device detection from an embedded WKWebView on iPadOS without this change: |
ibc
reviewed
Oct 6, 2023
ibc
reviewed
Oct 6, 2023
| @@ -188,7 +190,6 @@ export function detectDevice(): BuiltinHandlerName | undefined | |||
| else if ( | |||
| engineName === 'webkit' && | |||
| isIOS && | |||
| osVersion >= 14.3 && | |||
There was a problem hiding this comment.
I understand this is not super required, but what is wrong with it? Is this version requirement generating some issue?
There was a problem hiding this comment.
Yes, iPadOS WKWebView reports as OS Version 10.15.
Co-authored-by: Iñaki Baz Castillo <[email protected]>
|
Thanks, I'll merge and release next Monday or before if I can. |
|
Sorry for the delay. Released in 3.6.102. |
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
iPadOS identifies as Mac OS, but ua-parser-js does the extra detection to determine if it's an iPad. Use the device model to detect when we're in an embedded webview on iPadOS.
Also removes the version check for best effort webkit detection as iPadOS sends version 10.15 and checking RTCRtpTransceiver should be sufficient without the version check.