Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: mobile UA parsing, in-app ios browsers, add test cases #269

Closed
wants to merge 1 commit into from
Closed

fix: mobile UA parsing, in-app ios browsers, add test cases #269

wants to merge 1 commit into from

Conversation

palashgo
Copy link

@palashgo palashgo commented Jun 17, 2023 •
edited
Loading

Also I believe iOS Chrome was not using the correct handlers earlier, in both bowser and ua-parser-js it is detected as Chrome, making mediasoup use Chrome handlers while it is a Webkit WebView

IMG_1755

@ibc ibc mentioned this pull request Jun 19, 2023
Merged
@ibc
Copy link
Member

ibc commented Jun 19, 2023

Thanks.

I wanted to push some changes but somwhow gh NPM library forks the PR so I ended creating a new PR by accident: #270

@ibc
Copy link
Member

ibc commented Jun 19, 2023

Closing in favour of #270

@ibc ibc closed this Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@palashgo @ibc