refactor(turbo-tasks): Implement NonLocalValue for *all* ResolvedVcs and OperationVcs

[bgw]

This is a follow-up to #73714

What is NonLocalValue? https://turbopack-rust-docs.vercel.sh/rustdoc/turbo_tasks/trait.NonLocalValue.html

The core change here is this bit in turbopack/crates/turbo-tasks/src/vc/local.rs:

- unsafe impl<T: ?Sized + NonLocalValue> NonLocalValue for OperationVc<T> {}
- unsafe impl<T: ?Sized + NonLocalValue> NonLocalValue for ResolvedVc<T> {}
+ unsafe impl<T: ?Sized> NonLocalValue for OperationVc<T> {}
+ unsafe impl<T: ?Sized> NonLocalValue for ResolvedVc<T> {}

These new implementations are intentionally incorrect, as these values T could contain references to local Vc values. We must also check that T: NonLocalValue. However, we're temporarily ignoring that problem, as:

• We don't currently depend on NonLocalValue for safety (local tasks aren't enabled).
• We intend to make all VcValueTypes implement NonLocalValue, so implementing this for all values is approximating that future state.
• Adding a T: NonLocalValue bound introduces a lot of noise that isn't directly actionable for types that include a ResolvedVc or OperationVc that is not yet a NonLocalValue.

This PR also adds the NonLocalValue to types explicitly deriving TraceRawVcs, for types that couldn't before, by using the new weaker bounds on the NonLocalValue impls.

Closes PACK-3642

[bgw]

• refactor(turbo-tasks): Make State require OperationValue #73876
• refactor(turbopack): Make various types directly or indirectly included in State<T> types into OperationValues and/or NonLocalValues #74008
• refactor(turbo-tasks): Remove public OperationVc constructor, introduce a macro annotation for creating OperationVc types #72871
• chore(turbopack-browser): Pedantically fix minor typos in comments about TraitRef #73772
• refactor(turbo-tasks): Implement NonLocalValue for State<T> where T: NonLocalValue #73770
• refactor(turbo-tasks): Derive NonLocalValue by default in value/value_trait macros #73766
• refactor(turbo-tasks): Implement NonLocalValue for *all* ResolvedVcs and OperationVcs #73764 👈 (View in Graphite)
• canary

This stack of pull requests is managed by Graphite. Learn more about stacking.

[ijjk]

Stats from current PR

Default Build (Increase detected ⚠️)

General

	vercel/next.js canary	vercel/next.js bgw/impl-more-non-local-value	Change
buildDuration	18.5s	15.5s	N/A
buildDurationCached	14.7s	12.3s	N/A
nodeModulesSize	409 MB	409 MB	N/A
nextStartRea..uration (ms)	476ms	476ms	✓

Client Bundles (main, webpack)

	vercel/next.js canary	vercel/next.js bgw/impl-more-non-local-value	Change
1187-HASH.js gzip	50.7 kB	50.7 kB	N/A
8276.HASH.js gzip	169 B	168 B	N/A
8377-HASH.js gzip	5.36 kB	5.36 kB	N/A
bccd1874-HASH.js gzip	53 kB	53 kB	N/A
framework-HASH.js gzip	57.5 kB	57.5 kB	N/A
main-app-HASH.js gzip	233 B	236 B	N/A
main-HASH.js gzip	34 kB	34 kB	N/A
webpack-HASH.js gzip	1.71 kB	1.71 kB	N/A
Overall change	0 B	0 B	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	vercel/next.js bgw/impl-more-non-local-value	Change
polyfills-HASH.js gzip	39.4 kB	39.4 kB	✓
Overall change	39.4 kB	39.4 kB	✓

Client Pages

	vercel/next.js canary	vercel/next.js bgw/impl-more-non-local-value	Change
_app-HASH.js gzip	193 B	193 B	✓
_error-HASH.js gzip	193 B	193 B	✓
amp-HASH.js gzip	512 B	510 B	N/A
css-HASH.js gzip	343 B	342 B	N/A
dynamic-HASH.js gzip	1.84 kB	1.84 kB	✓
edge-ssr-HASH.js gzip	265 B	265 B	✓
head-HASH.js gzip	363 B	362 B	N/A
hooks-HASH.js gzip	393 B	392 B	N/A
image-HASH.js gzip	4.49 kB	4.49 kB	N/A
index-HASH.js gzip	268 B	268 B	✓
link-HASH.js gzip	2.35 kB	2.34 kB	N/A
routerDirect..HASH.js gzip	328 B	328 B	✓
script-HASH.js gzip	397 B	397 B	✓
withRouter-HASH.js gzip	323 B	326 B	N/A
1afbb74e6ecf..834.css gzip	106 B	106 B	✓
Overall change	3.59 kB	3.59 kB	✓

Client Build Manifests

	vercel/next.js canary	vercel/next.js bgw/impl-more-non-local-value	Change
_buildManifest.js gzip	747 B	746 B	N/A
Overall change	0 B	0 B	✓

Rendered Page Sizes

	vercel/next.js canary	vercel/next.js bgw/impl-more-non-local-value	Change
index.html gzip	524 B	524 B	✓
link.html gzip	539 B	539 B	✓
withRouter.html gzip	520 B	520 B	✓
Overall change	1.58 kB	1.58 kB	✓

Edge SSR bundle Size

	vercel/next.js canary	vercel/next.js bgw/impl-more-non-local-value	Change
edge-ssr.js gzip	128 kB	128 kB	N/A
page.js gzip	203 kB	203 kB	N/A
Overall change	0 B	0 B	✓

Middleware size

	vercel/next.js canary	vercel/next.js bgw/impl-more-non-local-value	Change
middleware-b..fest.js gzip	671 B	667 B	N/A
middleware-r..fest.js gzip	155 B	156 B	N/A
middleware.js gzip	31.1 kB	31.2 kB	N/A
edge-runtime..pack.js gzip	844 B	844 B	✓
Overall change	844 B	844 B	✓

Next Runtimes

	vercel/next.js canary	vercel/next.js bgw/impl-more-non-local-value	Change
523-experime...dev.js gzip	322 B	322 B	✓
523.runtime.dev.js gzip	314 B	314 B	✓
app-page-exp...dev.js gzip	323 kB	323 kB	✓
app-page-exp..prod.js gzip	127 kB	127 kB	✓
app-page-tur..prod.js gzip	140 kB	140 kB	✓
app-page-tur..prod.js gzip	135 kB	135 kB	✓
app-page.run...dev.js gzip	313 kB	313 kB	✓
app-page.run..prod.js gzip	123 kB	123 kB	✓
app-route-ex...dev.js gzip	37.3 kB	37.3 kB	✓
app-route-ex..prod.js gzip	25.4 kB	25.4 kB	✓
app-route-tu..prod.js gzip	25.4 kB	25.4 kB	✓
app-route-tu..prod.js gzip	25.2 kB	25.2 kB	✓
app-route.ru...dev.js gzip	38.9 kB	38.9 kB	✓
app-route.ru..prod.js gzip	25.2 kB	25.2 kB	✓
pages-api-tu..prod.js gzip	9.67 kB	9.67 kB	✓
pages-api.ru...dev.js gzip	11.6 kB	11.6 kB	✓
pages-api.ru..prod.js gzip	9.66 kB	9.66 kB	✓
pages-turbo...prod.js gzip	21.7 kB	21.7 kB	✓
pages.runtim...dev.js gzip	27.4 kB	27.4 kB	✓
pages.runtim..prod.js gzip	21.7 kB	21.7 kB	✓
server.runti..prod.js gzip	916 kB	916 kB	✓
Overall change	2.36 MB	2.36 MB	✓

build cache Overall increase ⚠️

	vercel/next.js canary	vercel/next.js bgw/impl-more-non-local-value	Change
0.pack gzip	2.05 MB	2.05 MB	⚠️ +127 B
index.pack gzip	72.4 kB	71.9 kB	N/A
Overall change	2.05 MB	2.05 MB	⚠️ +127 B

Diff details

Diff for main-HASH.js

Diff too large to display

Commit: 98314ca

[ijjk]

Tests Passed

[bgw]

Merge activity

• Dec 11, 11:48 AM EST: Graphite disabled "merge when ready" on this PR due to: a merge conflict with the target branch; resolve the conflict and try again..
• Dec 11, 2:23 PM EST: A user merged this pull request with Graphite.