kvstore: add GetMultiple #220
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add GetMultiple method to IKVStore that allows fetching values for multiple keys from a store with a single call. This simplifies the usage of the store inside trusted services and can potentially improve performance for remote store implementations where call overhead may be non-trivial. Signed-off-by: Sergei Trofimov <[email protected]>
|
|
||
| o.logger.Debugw("obtained endorsements", "endorsements", endorsements) | ||
| multEndorsements = append(multEndorsements, endorsements...) | ||
| endorsements, err := o.EnStore.GetMultiple(appraisal.EvidenceContext.ReferenceIds) |
There was a problem hiding this comment.
@setrofim : Why the same API is not applicable to line 448-452 ?
|
Also, is the same not true for Add() Interface, used with one example on main branch: |
|
Just checking since I have lost the context: is this change still required? |
It was more of a nice-to-have refactor. Given that we have larger issues looming around KVStore, I don't think this is worth the churn. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add GetMultiple method to IKVStore that allows fetching values for multiple keys from a store with a single call. This simplifies the usage of the store inside trusted services and can potentially improve performance for remote store implementations where call overhead may be non-trivial.
This addresses #207