chore: Get closer to core linting policy

.github/workflows/golangci-lint.yml

@@ -16,14 +16,14 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Setup Go
-        uses: actions/setup-go@v4
+        uses: actions/setup-go@v5
         with:
           go-version: '1.21.5'
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
       - name: golangci-lint
-        uses: golangci/golangci-lint-action@v3
+        uses: golangci/golangci-lint-action@v3.7.0
         with:
-          version: v1.53.2
-          args: --config .golangci.yaml --verbose
+          version: v1.55.2
+          args: --config .golangci.toml --verbose
         env:
           GO111MODULE: on 

.golangci.toml

@@ -0,0 +1,40 @@
+[run]
+allow-parallel-runners = true
+print-linter-name = true
+timeout = '15m0s'
+
+[output]
+print-issued-lines = true
+format = "colored-line-number"
+
+[issues]
+max-issues-per-linter = 0
+max-same-issues = 0
+exclude = [
+    "Error return value of .(.*MarkFlagRequired). is not checked"
+]
+
+[linters]
+disable-all = true
+enable = [
+    "errcheck",
+    "gosimple",
+    "govet",
+    "ineffassign",
+    "staticcheck",
+    "typecheck",
+    "unused",
+    "nilerr",
+    "misspell",
+    "gci"
+]
+
+[linters-settings.gci]
+custom-order = true
+sections = [
+    "standard", # Standard section: captures all standard packages.
+    "prefix(code.vegaprotocol.io/vega)", # Custom section: groups all imports with the specified Prefix.
+    "default", # Default section: contains all imports that could not be matched to another section type.
+    "blank", # Blank section: contains all blank imports. This section is not present unless explicitly enabled.
+    "dot",
+]

cmd/docs/main.go

@@ -6,6 +6,7 @@ import (
 	"strings"
 
 	"code.vegaprotocol.io/vegacapsule/docsgenerator"
+
 	"github.com/cometbft/cometbft/libs/os"
 )
 

cmd/ethereum.go

@@ -10,6 +10,7 @@ import (
 	"code.vegaprotocol.io/vegacapsule/state"
 	"code.vegaprotocol.io/vegacapsule/types"
 	"code.vegaprotocol.io/vegacapsule/utils"
+
 	"github.com/spf13/cobra"
 )
 

cmd/ethereum_asset.go

@@ -5,7 +5,6 @@ import (
 	"time"
 
 	vgtypes "github.com/ethereum/go-ethereum/core/types"
-
 	"github.com/spf13/cobra"
 )
 

cmd/ethereum_asset_deposit.go

@@ -5,8 +5,9 @@ import (
 	"fmt"
 	"math/big"
 
-	vgethereum "code.vegaprotocol.io/shared/libs/ethereum"
+	vgethereum "code.vegaprotocol.io/vegacapsule/libs/ethereum"
 	"code.vegaprotocol.io/vegacapsule/state"
+
 	"github.com/ethereum/go-ethereum/common"
 	"github.com/spf13/cobra"
 )
@@ -20,13 +21,11 @@ type ethereumAssetDepositOrStakeArgs struct {
 	networkAddress  string
 }
 
-var (
-	ethereumAssetDepositFlags = struct {
-		vegaPubKey  string
-		assetSymbol string
-		amount      int64
-	}{}
-)
+var ethereumAssetDepositFlags = struct {
+	vegaPubKey  string
+	assetSymbol string
+	amount      int64
+}{}
 
 func init() {
 	ethereumAssetDepositCmd.Flags().StringVar(&ethereumAssetDepositFlags.assetSymbol, "asset-symbol", "", "symbol of the asset to be deposited")

cmd/ethereum_asset_mint.go

@@ -5,8 +5,9 @@ import (
 	"fmt"
 	"math/big"
 
-	vgethereum "code.vegaprotocol.io/shared/libs/ethereum"
+	vgethereum "code.vegaprotocol.io/vegacapsule/libs/ethereum"
 	"code.vegaprotocol.io/vegacapsule/state"
+
 	"github.com/ethereum/go-ethereum/common"
 	"github.com/spf13/cobra"
 )
@@ -19,13 +20,11 @@ type ethereumAssetMintArgs struct {
 	networkAddress  string
 }
 
-var (
-	ethereumAssetMintFlags = struct {
-		toAddress   string
-		assetSymbol string
-		amount      int64
-	}{}
-)
+var ethereumAssetMintFlags = struct {
+	toAddress   string
+	assetSymbol string
+	amount      int64
+}{}
 
 func init() {
 	ethereumAssetMintCmd.Flags().StringVar(&ethereumAssetMintFlags.assetSymbol, "asset-symbol", "", "symbol of the asset to be minted")

cmd/ethereum_asset_stake.go

@@ -5,19 +5,18 @@ import (
 	"fmt"
 	"math/big"
 
-	vgethereum "code.vegaprotocol.io/shared/libs/ethereum"
+	vgethereum "code.vegaprotocol.io/vegacapsule/libs/ethereum"
 	"code.vegaprotocol.io/vegacapsule/state"
+
 	"github.com/ethereum/go-ethereum/common"
 	"github.com/spf13/cobra"
 )
 
-var (
-	ethereumAssetStakeFlags = struct {
-		vegaPubKey  string
-		assetSymbol string
-		amount      int64
-	}{}
-)
+var ethereumAssetStakeFlags = struct {
+	vegaPubKey  string
+	assetSymbol string
+	amount      int64
+}{}
 
 func init() {
 	ethereumAssetStakeCmd.Flags().StringVar(&ethereumAssetStakeFlags.assetSymbol, "asset-symbol", "", "symbol of the asset to be staked")

cmd/install_dependencies.go

@@ -4,11 +4,11 @@ import (
 	"fmt"
 	"os"
 
-	"github.com/spf13/cobra"
-
 	"code.vegaprotocol.io/vegacapsule/config"
 	"code.vegaprotocol.io/vegacapsule/installer"
 	"code.vegaprotocol.io/vegacapsule/utils"
+
+	"github.com/spf13/cobra"
 )
 
 const (

cmd/jobs_start.go

@@ -8,6 +8,7 @@ import (
 	"code.vegaprotocol.io/vegacapsule/config"
 	"code.vegaprotocol.io/vegacapsule/nomad"
 	"code.vegaprotocol.io/vegacapsule/state"
+
 	"github.com/spf13/cobra"
 )
 

cmd/jobs_stop.go

@@ -7,6 +7,7 @@ import (
 
 	"code.vegaprotocol.io/vegacapsule/nomad"
 	"code.vegaprotocol.io/vegacapsule/state"
+
 	"github.com/spf13/cobra"
 )
 

cmd/logs.go

@@ -5,6 +5,7 @@ import (
 
 	"code.vegaprotocol.io/vegacapsule/logscollector"
 	"code.vegaprotocol.io/vegacapsule/state"
+
 	"github.com/spf13/cobra"
 )
 

cmd/network_addresses.go

@@ -10,6 +10,7 @@ import (
 	"code.vegaprotocol.io/vegacapsule/ports"
 	"code.vegaprotocol.io/vegacapsule/state"
 	"code.vegaprotocol.io/vegacapsule/types"
+
 	"github.com/spf13/cobra"
 )
 

cmd/network_bootstrap.go

@@ -8,6 +8,7 @@ import (
 	"code.vegaprotocol.io/vegacapsule/installer"
 	"code.vegaprotocol.io/vegacapsule/state"
 	"code.vegaprotocol.io/vegacapsule/types"
+
 	"github.com/spf13/cobra"
 )
 

cmd/network_destroy.go

@@ -8,6 +8,7 @@ import (
 
 	"code.vegaprotocol.io/vegacapsule/nomad"
 	"code.vegaprotocol.io/vegacapsule/state"
+
 	"github.com/spf13/cobra"
 )
 

cmd/network_generate.go

@@ -12,6 +12,7 @@ import (
 	"code.vegaprotocol.io/vegacapsule/state"
 	"code.vegaprotocol.io/vegacapsule/types"
 	"code.vegaprotocol.io/vegacapsule/utils"
+
 	"github.com/spf13/cobra"
 )
 

cmd/network_keys_import.go

@@ -9,6 +9,7 @@ import (
 
 	"code.vegaprotocol.io/vegacapsule/importer"
 	"code.vegaprotocol.io/vegacapsule/state"
+
 	"github.com/spf13/cobra"
 )
 
@@ -48,9 +49,7 @@ Example content of the file with data to import:
 	...
   ]`
 
-var (
-	keysFilePath string
-)
+var keysFilePath string
 
 var netKeysImportCmd = &cobra.Command{
 	Use:          "import",

cmd/network_logs.go

@@ -9,6 +9,7 @@ import (
 	"code.vegaprotocol.io/vegacapsule/nomad"
 	"code.vegaprotocol.io/vegacapsule/state"
 	"code.vegaprotocol.io/vegacapsule/types"
+
 	"github.com/spf13/cobra"
 )
 

cmd/network_start.go

@@ -8,12 +8,11 @@ import (
 	"code.vegaprotocol.io/vegacapsule/config"
 	"code.vegaprotocol.io/vegacapsule/nomad"
 	"code.vegaprotocol.io/vegacapsule/state"
+
 	"github.com/spf13/cobra"
 )
 
-var (
-	doNotStopAllJobsOnFailure bool
-)
+var doNotStopAllJobsOnFailure bool
 
 var netStartCmd = &cobra.Command{
 	Use:   "start",

cmd/network_stop.go

@@ -7,12 +7,11 @@ import (
 
 	"code.vegaprotocol.io/vegacapsule/nomad"
 	"code.vegaprotocol.io/vegacapsule/state"
+
 	"github.com/spf13/cobra"
 )
 
-var (
-	stopNodesOnly bool
-)
+var stopNodesOnly bool
 
 var netStopCmd = &cobra.Command{
 	Use:   "stop",

cmd/nodes_add.go

@@ -10,6 +10,7 @@ import (
 	"code.vegaprotocol.io/vegacapsule/nomad"
 	"code.vegaprotocol.io/vegacapsule/state"
 	"code.vegaprotocol.io/vegacapsule/types"
+
 	"github.com/spf13/cobra"
 	"golang.org/x/sync/errgroup"
 )
@@ -89,7 +90,7 @@ var nodesAddCmd = &cobra.Command{
 
 		fmt.Println(string(outputStringJSON))
 		if resultsOutPath != "" {
-			if err := os.WriteFile(resultsOutPath, outputStringJSON, 0666); err != nil {
+			if err := os.WriteFile(resultsOutPath, outputStringJSON, 0o666); err != nil {
 				return fmt.Errorf("failed to save results about new nodes into the file: %w", err)
 			}
 		}

cmd/nodes_list.go

@@ -5,6 +5,7 @@ import (
 	"fmt"
 
 	"code.vegaprotocol.io/vegacapsule/state"
+
 	"github.com/spf13/cobra"
 )
 

cmd/nodes_list_validators.go

@@ -5,6 +5,7 @@ import (
 	"fmt"
 
 	"code.vegaprotocol.io/vegacapsule/state"
+
 	"github.com/spf13/cobra"
 )
 

cmd/nodes_protocol_upgrade.go

@@ -9,6 +9,7 @@ import (
 	"code.vegaprotocol.io/vegacapsule/generator/visor"
 	"code.vegaprotocol.io/vegacapsule/state"
 	"code.vegaprotocol.io/vegacapsule/types"
+
 	"github.com/spf13/cobra"
 )
 

cmd/nodes_remove.go

@@ -1,11 +1,13 @@
 package cmd
 
 import (
+	"context"
+	"fmt"
+
 	"code.vegaprotocol.io/vegacapsule/generator"
 	"code.vegaprotocol.io/vegacapsule/nomad"
 	"code.vegaprotocol.io/vegacapsule/state"
-	"context"
-	"fmt"
+
 	"github.com/spf13/cobra"
 )
 

cmd/nodes_reset_state.go

@@ -7,6 +7,7 @@ import (
 
 	"code.vegaprotocol.io/vegacapsule/commands"
 	"code.vegaprotocol.io/vegacapsule/state"
+
 	"github.com/spf13/cobra"
 )