Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

10995 liquidation range #11152

Merged
merged 14 commits into from
Apr 18, 2024
Merged

10995 liquidation range #11152

merged 14 commits into from
Apr 18, 2024

Conversation

EVODelavega
Copy link
Contributor

@EVODelavega EVODelavega commented Apr 18, 2024 •
edited
Loading

Closes #10995

{
    "system-tests": "liquidation_slippage"
}

@EVODelavega EVODelavega requested review from candida-d and a team as code owners April 18, 2024 12:07
@EVODelavega EVODelavega force-pushed the 10995-liquidation-range branch from ee3053c to 0b5c5d9 Compare April 18, 2024 13:25
@EVODelavega EVODelavega requested a review from a team as a code owner April 18, 2024 14:54
@EVODelavega
feat: use liquidation parameter to set price range
97fd8c8 
Signed-off-by: Elias Van Ootegem <[email protected]>
@EVODelavega
test: fix integration tests to work with new disposal slippage parameter
93fe7a6 
Signed-off-by: Elias Van Ootegem <[email protected]>
@EVODelavega
test: tweak integration, fix unit tests after adding validation to th…
790eba6 
…e new parameter

Signed-off-by: Elias Van Ootegem <[email protected]>
@EVODelavega
test: add coverage for proposal disposal slippage validation
9b0a8de 
Signed-off-by: Elias Van Ootegem <[email protected]>
@EVODelavega
chore: comment out scenario without implementation
0555e41 
Signed-off-by: Elias Van Ootegem <[email protected]>
@EVODelavega
chore: review
6e8ab48 
Signed-off-by: Elias Van Ootegem <[email protected]>
@EVODelavega
test: fix type unit tests
0b7819f 
Signed-off-by: Elias Van Ootegem <[email protected]>
@EVODelavega
chore: review fixes
b93764a 
Signed-off-by: Elias Van Ootegem <[email protected]>
@EVODelavega
fix: remove duplicate mid-price func
e782714 
Signed-off-by: Elias Van Ootegem <[email protected]>
@EVODelavega
feat: add migration checks and events to governance engine
a587816 
Signed-off-by: Elias Van Ootegem <[email protected]>
@EVODelavega
feat: emit update events on upgrade, add types to datanode and GQL
7ebde91 
Signed-off-by: Elias Van Ootegem <[email protected]>
@EVODelavega
test: update datanode unit tests
fcdbccf 
Signed-off-by: Elias Van Ootegem <[email protected]>
@EVODelavega EVODelavega force-pushed the 10995-liquidation-range branch from c9ccf2c to fcdbccf Compare April 18, 2024 15:29
@EVODelavega EVODelavega merged commit ad4121e into develop Apr 18, 2024
18 checks passed
@EVODelavega EVODelavega deleted the 10995-liquidation-range branch April 18, 2024 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wwestgarth wwestgarth wwestgarth left review comments

@jeremyletang jeremyletang jeremyletang approved these changes

@candida-d candida-d Awaiting requested review from candida-d candida-d is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature] Liquidation strategy to have its own range
3 participants
@EVODelavega @wwestgarth @jeremyletang