Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Arbitrum bridge #10632

Merged
merged 18 commits into from
Mar 27, 2024
Merged

Support Arbitrum bridge #10632

merged 18 commits into from
Mar 27, 2024

Conversation

ValentinTrinque
Copy link
Contributor

@ValentinTrinque ValentinTrinque commented Feb 13, 2024 •
edited
Loading

Closes #10610
Closes #10854
Closes #10717
Closes #10853

@ValentinTrinque ValentinTrinque added this to the 🏛️ Colosseo milestone Feb 13, 2024
@ValentinTrinque ValentinTrinque self-assigned this Feb 13, 2024
@ValentinTrinque ValentinTrinque force-pushed the epic/arbitrum branch 7 times, most recently from 08adcb6 to 00630bf Compare February 20, 2024 11:15
@ValentinTrinque ValentinTrinque force-pushed the epic/arbitrum branch 5 times, most recently from 143d279 to 4b48767 Compare February 28, 2024 09:40
@ValentinTrinque ValentinTrinque force-pushed the epic/arbitrum branch 4 times, most recently from b99171e to d0dbfd7 Compare March 5, 2024 09:46
@ValentinTrinque ValentinTrinque force-pushed the epic/arbitrum branch 2 times, most recently from 635921d to 7cc23f5 Compare March 11, 2024 09:26
@ValentinTrinque
Copy link
Contributor Author

ValentinTrinque commented Mar 11, 2024 •
edited by wwestgarth
Loading 

{
  "system-tests": "epic/arbitrum",
  "vegacapsule": "epic/arbitrum",
  "vega-market-sim": "support-second-bridge"
}

@ValentinTrinque ValentinTrinque force-pushed the epic/arbitrum branch 5 times, most recently from 85e2f0d to 0844d08 Compare March 17, 2024 15:24
@wwestgarth wwestgarth marked this pull request as ready for review March 26, 2024 10:34
@wwestgarth wwestgarth requested a review from candida-d as a code owner March 26, 2024 10:34
peterbarrow
peterbarrow previously approved these changes Mar 26, 2024
View reviewed changes
core/evtforward/engine.go Outdated Show resolved Hide resolved
core/netparams/keys.go Outdated Show resolved Hide resolved
candida-d
candida-d reviewed Mar 26, 2024
View reviewed changes
core/netparams/keys.go Outdated Show resolved Hide resolved
@wwestgarth wwestgarth mentioned this pull request Mar 26, 2024
Merged
ValentinTrinque and others added 18 commits March 27, 2024 08:52
@ValentinTrinque @wwestgarth
feat: Convert all assets to be associated to the configured Ethereum …
bb0f0af 
…chain
@ValentinTrinque @wwestgarth
fix: Value assets chain ID using network parameters
a95bcb9 
Non-validator nodes do not have a Ethereum client setup, so we can't use it to value the assets' chain ID.
@ValentinTrinque @wwestgarth
feat: Account for missing chain ID when deduplicating chain events
2795aa0
@ValentinTrinque @wwestgarth
feat: Introduce secondary ethereum client
02848a7
@ValentinTrinque @wwestgarth
feat: Expose asset's chain ID
cd83502
@wwestgarth
feat: implement multisig tracking and signature gen for second bridge
aec52b4
@ValentinTrinque @wwestgarth
fix: Clean up unused tracked network parameters during protocol upgrade
99db863 
The specific network parameters involved in the protocol upgrade are not used anymore, as we are broadcasting an event for all network parameters now.

So there is no need to track them anymore, and can safely rely on a simple boolean.
@ValentinTrinque @wwestgarth
fix: Determine protocol upgrade from context and not snapshot state
6ad3e0e
@ValentinTrinque @wwestgarth
feat: scaffold the hardcoded secondary ethereum configuration
54362d5
@wwestgarth
chore: improve doc-strings for add/remove signer sig-bundle API
183f70e
@wwestgarth
fix: issues with rebase
83dca68
@wwestgarth
fix: save secondary bridge state in snapshot
1efcf22
@wwestgarth
fix: validate EVM chain ID in asset proposal earlier on in governance…
4b7597a 
… flow
@wwestgarth @gordsport
chore: apply suggestions from protos doc review
6eb269a 
Co-authored-by: Gordsport <[email protected]>
@wwestgarth
fix: stage asset migration updates so that they get sent out on the n…
29c2bd8 
…ext tick
@wwestgarth
chore: relax migration check until we know what version we are upgrad…
f7e9aab 
…ing from
@wwestgarth
chore: rename network parameter for second bridge config
3bdc335
@wwestgarth
chore: rename spam network parameter
e907787
@wwestgarth wwestgarth merged commit 9a412f9 into develop Mar 27, 2024
20 checks passed
@wwestgarth wwestgarth deleted the epic/arbitrum branch March 27, 2024 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gordsport gordsport gordsport left review comments

@candida-d candida-d candida-d approved these changes

@davidsiska-vega davidsiska-vega davidsiska-vega approved these changes

@EVODelavega EVODelavega EVODelavega approved these changes

@peterbarrow peterbarrow peterbarrow left review comments

@wwestgarth wwestgarth wwestgarth left review comments

Assignees

@ValentinTrinque ValentinTrinque

Labels
arbitrum bridges
Projects
None yet
Milestone
🏛️ Colosseo
7 participants
@ValentinTrinque @wwestgarth @EVODelavega @peterbarrow @davidsiska-vega @candida-d @gordsport