fix: Value assets chain ID using network parameters

Non-validator nodes do not have a Ethereum client setup, so we can't use it to value the assets' chain ID.

core/assets/assets.go

@@ -75,7 +75,8 @@ type Service struct {
 	ethToVega   map[string]string
 	isValidator bool
 
-	bridgeView ERC20BridgeView
+	bridgeView      ERC20BridgeView
+	ethereumChainID string
 }
 
 func New(
@@ -462,3 +463,7 @@ func (s *Service) validateAsset(a *Asset) error {
 
 	return err
 }
+
+func (s *Service) OnEthereumChainIDUpdated(chainID string) {
+	s.ethereumChainID = chainID
+}

core/assets/erc20/erc20.go

@@ -44,7 +44,6 @@ type ETHClient interface {
 	CollateralBridgeAddress() ethcommon.Address
 	CurrentHeight(context.Context) (uint64, error)
 	ConfirmationsRequired() uint64
-	ConfiguredChainID() string
 }
 
 type ERC20 struct {

core/assets/erc20/erc20_test.go

@@ -122,10 +122,6 @@ type testEthClient struct {
 	bind.ContractBackend
 }
 
-func (testEthClient) ConfiguredChainID() string {
-	return "1"
-}
-
 func (testEthClient) HeaderByNumber(context.Context, *big.Int) (*ethtypes.Header, error) {
 	return nil, nil
 }

core/assets/snapshot.go

@@ -206,7 +206,7 @@ func (s *Service) applyMigrations(ctx context.Context, p *types.Asset) {
 		// the chain ID they originated from. So, when loaded, assets without a chain
 		// ID are automatically considered to originate from Ethereum Mainnet.
 		if erc20 := p.Details.GetERC20(); erc20 != nil && erc20.ChainID == "" {
-			erc20.ChainID = s.ethClient.ConfiguredChainID()
+			erc20.ChainID = s.ethereumChainID
 			// Ensure the assets are updated in the data-node.
 			s.broker.Send(events.NewAssetEvent(ctx, *p))
 		}

core/client/eth/client.go

@@ -70,10 +70,6 @@ func Dial(ctx context.Context, cfg Config) (*Client, error) {
 	return &Client{ETHClient: newEthClientWrapper(ethClient), cfg: cfg}, nil
 }
 
-func (c *Client) ConfiguredChainID() string {
-	return c.ethConfig.ChainID()
-}
-
 func (c *Client) UpdateEthereumConfig(ctx context.Context, ethConfig *types.EthereumConfig) error {
 	if c == nil {
 		return nil

core/protocol/all_services.go

@@ -877,6 +877,18 @@ func (svcs *allServices) setupNetParameters(powWatchers []netparams.WatchParam)
 				return nil
 			},
 		},
+		{
+			Param: netparams.BlockchainsEthereumConfig,
+			Watcher: func(_ context.Context, cfg interface{}) error {
+				ethCfg, err := types.EthereumConfigFromUntypedProto(cfg)
+				if err != nil {
+					return fmt.Errorf("invalid ethereum configuration: %w", err)
+				}
+
+				svcs.assets.OnEthereumChainIDUpdated(ethCfg.ChainID())
+				return nil
+			},
+		},
 		{
 			Param: netparams.BlockchainsEthereumL2Configs,
 			Watcher: func(ctx context.Context, cfg interface{}) error {