chore: review fixes

Signed-off-by: Elias Van Ootegem <[email protected]>

core/execution/liquidation/engine.go

@@ -129,18 +129,19 @@ func (e *Engine) Update(cfg *types.LiquidationStrategy) {
 }
 
 func (e *Engine) OnTick(ctx context.Context, now time.Time, midPrice *num.Uint) (*types.Order, error) {
-	if e.pos.open == 0 || e.as.InAuction() || e.nextStep.After(now) {
+	if e.pos.open == 0 || e.as.InAuction() || e.nextStep.After(now) || midPrice.IsZero() {
 		return nil, nil
 	}
 
+	one := num.DecimalOne()
 	// get the min/max price from the range based on slippage parameter
 	mpDec := num.DecimalFromUint(midPrice)
 	minP := num.UintZero()
-	if e.cfg.DisposalSlippage.LessThan(num.DecimalZero()) {
-		minD := mpDec.Mul(num.DecimalZero().Sub(e.cfg.DisposalSlippage))
+	if e.cfg.DisposalSlippage.LessThan(one) {
+		minD := mpDec.Mul(one.Sub(e.cfg.DisposalSlippage))
 		minP, _ = num.UintFromDecimal(minD)
 	}
-	maxD := mpDec.Mul(num.DecimalZero().Add(e.cfg.DisposalSlippage))
+	maxD := mpDec.Mul(one.Add(e.cfg.DisposalSlippage))
 	maxP, _ := num.UintFromDecimal(maxD)
 
 	minB, maxB := e.pmon.GetValidPriceRange()

protos/sources/vega/markets.proto

@@ -414,7 +414,7 @@ message LiquidationStrategy {
   // Max fraction of the total volume of the orderbook, within liquidity bounds, that the network can use to close its position; range 0 through 1.
   string max_fraction_consumed = 4;
   // Decimal > 0 defining the price range within which the network will trade to dispose of its position. Retroactively defaults to 0.1 (10%).
-  // The value can be > 1, if set to 1.5, the minimum price will be 0 (min(0, mid_price * (1 - 1.))), the maximum price will be mid_price * (1 + 1.5).
+  // The value can be > 1, if set to 1.5, the minimum price will be 0 (max(0, mid_price * (1 - 1.5))), the maximum price will be mid_price * (1 + 1.5).
   string disposal_slippage_range = 5;
 }