feat: average notional position #2321
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdummett
force-pushed
the
feat/average_notional
branch
from
c04a704 to
e7f4071
Compare
cdummett
force-pushed
the
feat/average_notional
branch
from
e7f4071 to
ca36524
Compare
Jiajia-Cui
previously approved these changes
Aug 6, 2024
Jiajia-Cui
previously approved these changes
Aug 6, 2024
Merged
|
closed in favour of: #2336 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous PR #2316 reverted as merged early before release targeted.
Summary
spec change for ticket vegaprotocol/vega#11459
Summary
To enable cross-market reward schemes rewarding large positions....
PR renames average position metric to average notional position metric and updates formulas and AC codes.
Outstanding questions...
Can this metric simply be updated (keeping name) or do we require a new metric.
DO NOT MERGE
Release prioritisation must be complete before spec PR can be merged into relevant branch.