Update 0072-SPPW-spam-protection-PoW.md #1702
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…specs into eth_changes_during_outages
feat: Add new cases, mostly around eth changes during outages. A few …
chore: remove invalid and unimplemented use cases
refactor: floor slippage
* draft for SORD * add AC for showing rejected reason * typo * execution flags on orders table * add codes to SORD * Update user-interface/7002-SORD-submit_orders.md Co-authored-by: candida-d <[email protected]> * add link to docs --------- Co-authored-by: candida-d <[email protected]>
* Clarify rewards if multisig contains a key it should not * fix: MD lint error --------- Co-authored-by: gordsport <[email protected]>
feat: update FOK MO reduce-only
Co-authored-by: Tom <[email protected]>
fix: Add some more cancel order ACs.
#1637) * feat: Add a test for checking performance scores when checkpoint restart happens in a new epoch. * fix: Typo. * chore: Fix indentation (tabs/spaces).
#1637) * feat: Add a test for checking performance scores when checkpoint restart happens in a new epoch. * fix: Typo. * chore: Fix indentation (tabs/spaces).
Deleted half an AC as discussed on slack (as the number for the performance score didn't make sense here)
* refactor: update ACs * chore: tell approbation to leave me alone * chore: try again * refactor: rephrase AC * refactor: clarify * refactor: fix spelling
…nctionality to fetch csv files containing network history (#1659) * feat: update datanode spec with functionality to rollback node and functionality to fetch csv files containing network history * fix: spell checker --------- Co-authored-by: gordsport <[email protected]> Co-authored-by: Gordsport <[email protected]>
* spec: draft for time-based mempool pruning Signed-off-by: Elias Van Ootegem <[email protected]> * spec: spelling Signed-off-by: Elias Van Ootegem <[email protected]> * Spelling + clarify how block height is determined Signed-off-by: Elias Van Ootegem <[email protected]> * spec: add some additional ACs, remove mention of TxV4, clarify that transaction data includes block hash in addition to block height Signed-off-by: Elias Van Ootegem <[email protected]> * complete acceptance criteria Signed-off-by: Elias Van Ootegem <[email protected]> * fix typo Signed-off-by: Elias Van Ootegem <[email protected]> --------- Signed-off-by: Elias Van Ootegem <[email protected]> Co-authored-by: Gordsport <[email protected]>
* chore: Add decision notes template Added a decision template based loosely on the [Any Decision Records](https://adr.github.io/madr/) template Also updated some MD linting to allow sibling duplicated header titles and double spacing to make reading easier. * fix: Spelling error
feat: use ghcr image to run approbation
chore(trading): fix spec links
…rderbook-ACs-added chore(trading):add chart and orderbook ACs
add telemtry ac
remove browser wallet
Added clarification on event forwarding
Update 0036-BRIE-event_queue.md
Add some market successor specs
Update 6002-MDET-market-details.md
vega-paul
suggested changes
Aug 1, 2023
| @@ -128,3 +128,6 @@ All Vega clients that submitted transactions can verify that their transaction h | |||
|
|
|||
| - *Mempool pruning* Cause congestion in the mempool by submitting many transactions (perhaps from several parties). Submit a transaction `T` tied to block number `N_old`. Make sure the transactions causing congestion create sufficiently large `N_current`. At some point we'll have `N_old + spam.pow.numberOfPastBlocks < N_current` and the transaction `T` is removed from the mempool and never scheduled. (<a name="0072-SPPW-012" href="#0072-SPPW-012">0072-SPPW-012</a>) | |||
|
|
|||
| - Run the network on the borderline of capacity by submitting as many transactions as the network can process (possibly from many processes), causing short congestion spikes in individual blocks, but overall no congestion. Log all removed transactions removed through pruning, and verify they for all removed transactions `T`, all satisfied the condition that the block `N_t T` was tied to satisfies `N_t + spam.pow.numberOfPastBlocks < N_kickout`, where `N_kickout` is the block number processed when the transaction got pruned. (<a name="0072-SPPW-013" href="#0072-SPPW-013">0072-SPPW-013</a>) | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Acs for pruning the mempool
close #1678 .