Separate biome features and biome events on load, closes #190 #226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vectorwing
changed the title
|
Works fine for me under AdoptOpenJDK 8u282/11.0.10/15.0.2 with OpenJ9 0.26.0 |
|
Wonderful! Thanks for your time. 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the enhancements/fixes proposed in #190, by moving the
onBiomeLoadevent outside the class whereConfiguredFeature<?, ?>is stored. It also enqueues their registration correctly.@3TUSK and @ZekerZhayard, feel free to review this if you can, just to make sure this is what you meant. The changes work locally, but I could not test them with the OpenJ9 VM.