-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(operations): Kubernetes test procedure #2487
Conversation
bff1c29
to
a983d1a
Compare
39f2bbb
to
1fca1f7
Compare
Should I address sharing the |
I assume you mean sharing it across all of our CI jobs? I'd postpone it. I'm also not sure that's possible given that we build Vector with different features for different targets, right? |
Each of the kubernetes infrastructure tests (1.18, 1.17, etc) currently builds a full release build, then a .deb, and then builds a docker image and pushes it top a repo so that it's accessible to k8s cluster. It's enough to do all those steps once, and reuse the docker image. After the docker image is built - we also build the tests (with the kubernetes-specific features) - this is what you mentioned. This part we can't share among non-k8s tests - but across the k8s tests against multiple clusters we can share them too. Kubernetes tests are designed in a way that we deploy Vector into k8s - this is why we need to build not just the tests, but also the full vector binary (and docker image). |
Seems like
Login step was ok, so the token must not have access to push into |
I just added that user to the |
841e1ac
to
8e3b3e3
Compare
It's still failing |
Docker Hub's permissions are confusing. It should work now 😄 . |
3375240
to
871c86a
Compare
For some time, I was baffled with how we'd merge this without the Kubernetes implementation present. At the same time, I stumble upon the need to have this functionality at my implementation PR. I think I found the solution. I'll change the k8s related tests as "allow failed" for now (or do something similar), and we merge this. The downside is people will still see those jobs - but they won't affect build success. An alternative would be to close this PR and for me to take these changes in my impl PR, but that would needlessly bloat that other PR, complicate the reviews and limit the PR atomicity. |
Signed-off-by: MOZGIII <[email protected]>
Signed-off-by: MOZGIII <[email protected]>
Signed-off-by: MOZGIII <[email protected]>
Signed-off-by: MOZGIII <[email protected]>
606dcf4
to
3f19103
Compare
Signed-off-by: MOZGIII <[email protected]>
Signed-off-by: MOZGIII <[email protected]>
…at CI Signed-off-by: MOZGIII <[email protected]>
Signed-off-by: MOZGIII <[email protected]>
… ConfigMap Signed-off-by: MOZGIII <[email protected]>
Signed-off-by: MOZGIII <[email protected]>
Signed-off-by: MOZGIII <[email protected]>
Signed-off-by: MOZGIII <[email protected]>
Signed-off-by: MOZGIII <[email protected]>
3f19103
to
ef54966
Compare
Signed-off-by: MOZGIII <[email protected]>
I’m fine with that |
* Add deployment configs for Kubernetes (YAML files) Signed-off-by: MOZGIII <[email protected]> * Add a script to start a local docker registry Signed-off-by: MOZGIII <[email protected]> * Add the ability to customize the repo to push docker image to Signed-off-by: MOZGIII <[email protected]> * Outline the implementation of the integration-kubernetes GA job Signed-off-by: MOZGIII <[email protected]> * Add a kubernetes test running suite Signed-off-by: MOZGIII <[email protected]> * Add docker credentials and parameters Signed-off-by: MOZGIII <[email protected]> * Allow passing PACKAGE_DEB_USE_CONTAINER explicitly and set it docker at CI Signed-off-by: MOZGIII <[email protected]> * Allow vector-config secret as well as configmap Signed-off-by: MOZGIII <[email protected]> * Rename vector.toml to managed.toml at vector-daemonset-managed-config ConfigMap Signed-off-by: MOZGIII <[email protected]> * Remove the unnecessary comment Signed-off-by: MOZGIII <[email protected]> * Scope the global configs by the test namespace Signed-off-by: MOZGIII <[email protected]> * Temporarily disable kubernetes tests Signed-off-by: MOZGIII <[email protected]> * Do not fail fast the k8s tests Signed-off-by: MOZGIII <[email protected]> * Enable slim builds for k8s tests Signed-off-by: MOZGIII <[email protected]> Signed-off-by: Brian Menges <[email protected]>
This PR outlines the initial test procedure we agreed upon at #2222.
It only includes minikube tests at CI, and it should be very easy to add EKS or GKE one we set them up.
Closes #2223.