chore: Rename futures to futures01 #1933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MOZGIII
requested review from
bruceg,
LucioFranco and
lukesteensen
as code owners
|
Seems there is a merge conflict and thanks for opening this <3 |
MOZGIII
force-pushed
the
futures01-rename
branch
from
4077ff0 to
4403cb6
Compare
LucioFranco
approved these changes
Feb 26, 2020
This makes it easier for the whole team to spot old futures use and fix it in their local piece of work. Signed-off-by: MOZGIII <[email protected]>
Signed-off-by: MOZGIII <[email protected]>
MOZGIII
force-pushed
the
futures01-rename
branch
from
4403cb6 to
4f359b2
Compare
|
In the interest of keeping this from getting stale, I'd like to merge it asap. |
bruceg
approved these changes
Feb 26, 2020
|
once CI passes 🚢 it |
lukesteensen
approved these changes
Feb 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split off from #1922 after the discussion at #1922 (comment)