Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure thorbuilder doesnt colide on the same process #14

Merged
merged 7 commits into from
Feb 4, 2025
Merged

Ensure thorbuilder doesnt colide on the same process #14

merged 7 commits into from
Feb 4, 2025

Conversation

otherview
Copy link
Member

Describe your changes

As per title, changed the thorbuilder New method.

Issue ticket number and link

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have executed relevant tests
  • I have added thorough tests for the changes
  • Does this need a documentation update?

vanja-vechain
vanja-vechain approved these changes Feb 4, 2025
View reviewed changes
Copy link

@vanja-vechain vanja-vechain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

otherview
otherview commented Feb 4, 2025
View reviewed changes
thorbuilder/thorbuilder.go Outdated Show resolved Hide resolved
@otherview otherview merged commit cd8d200 into main Feb 4, 2025
8 checks passed
@otherview otherview deleted the pedro/update_thorbuilder branch February 4, 2025 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darrenvechain darrenvechain darrenvechain approved these changes

@vanja-vechain vanja-vechain vanja-vechain approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@otherview @darrenvechain @vanja-vechain