-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release: introduce magefile #156
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: vankichi <[email protected]>
Signed-off-by: vankichi <[email protected]>
Signed-off-by: vankichi <[email protected]>
Signed-off-by: vankichi <[email protected]>
Signed-off-by: vankichi <[email protected]>
0efadad
to
34caca8
Compare
Signed-off-by: vankichi <[email protected]>
e9657bb
to
2055c3b
Compare
Signed-off-by: vankichi <[email protected]>
Signed-off-by: vdaas-ci <[email protected]>
Signed-off-by: vankichi <[email protected]>
Signed-off-by: vdaas-ci <[email protected]>
Signed-off-by: vankichi <[email protected]>
Signed-off-by: vdaas-ci <[email protected]>
Signed-off-by: vankichi <[email protected]>
Signed-off-by: vdaas-ci <[email protected]>
Signed-off-by: vankichi <[email protected]>
Signed-off-by: vankichi <[email protected]>
2 tasks
Signed-off-by: vankichi <[email protected]>
Signed-off-by: vdaas-ci <[email protected]>
datelier
approved these changes
Jan 17, 2024
Signed-off-by: vankichi <[email protected]>
c16a572
to
3d220e4
Compare
Will you change the logic of the Other part looks good. |
Signed-off-by: vankichi <[email protected]>
Signed-off-by: vdaas-ci <[email protected]>
@ykadowak |
ykadowak
approved these changes
Jan 22, 2024
hlts2
approved these changes
Jan 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!!
kmrmt
approved these changes
Jan 23, 2024
kpango
approved these changes
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has some new attempts.
Makefile
, I have migrated file I/O operation to./magefile/magefile.go
and refactored./Makefile
make all
ormake TARGET_VER={X.Y.Z} all
description.json
for auto-update content filesdescription.json
includesweight
anddescription
for each document file, which shows content information on the website.repository_dispatch
and updates content files automatically.repository_dispatch
from thevdaas/vald
repository.