Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release: introduce magefile #156

Merged
merged 21 commits into from
Jan 25, 2024
Merged

Release: introduce magefile #156

merged 21 commits into from
Jan 25, 2024

Conversation

vankichi
Copy link
Contributor

@vankichi vankichi commented Jan 15, 2024

This PR has some new attempts.

  • Introduce magefile
    • Due to the complex Makefile, I have migrated file I/O operation to ./magefile/magefile.go and refactored ./Makefile
    • we can update content files by make all or make TARGET_VER={X.Y.Z} all
  • Add description.json for auto-update content files
    • description.json includes weight and description for each document file, which shows content information on the website.
  • Add a new GitHub workflow, which runs by repository_dispatch and updates content files automatically.
    • Until now, we have needed to manually update when the document file or Vald version is updated, wasting the maintainers' time. So, I have created a new workflow that updates the content file triggered by the repository_dispatch from the vdaas/vald repository.

@vankichi vankichi force-pushed the refactor/apply-magefile branch from 0efadad to 34caca8 Compare January 15, 2024 08:37
Signed-off-by: vankichi <[email protected]>
@vankichi vankichi force-pushed the refactor/apply-magefile branch from e9657bb to 2055c3b Compare January 15, 2024 08:41
vankichi and others added 10 commits January 15, 2024 17:42
Signed-off-by: vankichi <[email protected]>
Signed-off-by: vankichi <[email protected]>
Signed-off-by: vankichi <[email protected]>
Signed-off-by: vankichi <[email protected]>
Signed-off-by: vankichi <[email protected]>
@vankichi vankichi changed the title Refactor/apply magefile Release: introduce magefile Jan 16, 2024
vankichi and others added 2 commits January 16, 2024 17:46
@vankichi vankichi force-pushed the refactor/apply-magefile branch from c16a572 to 3d220e4 Compare January 17, 2024 07:54
@ykadowak
Copy link

Will you change the logic of the megefile.go not to use unnecessary regex?

Other part looks good.

vankichi and others added 2 commits January 22, 2024 13:28
@vankichi
Copy link
Contributor Author

@ykadowak
I have updated it. Could you please review it?

Copy link
Collaborator

@hlts2 hlts2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@vankichi vankichi merged commit 66bf6b4 into main Jan 25, 2024
4 checks passed
@vankichi vankichi deleted the refactor/apply-magefile branch January 25, 2024 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants