Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

few bugs, few operations, few algorithms... #1

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

wilkeraziz
Copy link

Hi Victor,

great job with the templates, I was trying to solve that and I was missing pystache.
Hey, I've made a few changes and added a few methods so that I could abstract a little more about the weight types in a few algorithms.

(Not for this pull request, but...) I wanted to ask you, if I organized the code in packages (including changing the setup.py, and changing the algorithms to pyx) would you feel like accepting another pull request?
I've tested here and it works, it is basically something like the following:

    pyfst/
      __init__.py
      cfst.pxd
      fst.pyx
      ...
      algorithm/
        __init__.py

Then we would have a structure like:
from pyfst.fst import LogVectorFst
from pyfst.algorithm.sampling import sample

@wilkeraziz
Copy link
Author

So, if you want you can check my fork to see how the package thing is looking like... then if you like I'll send you the request. Cheers!

@wilkeraziz
Copy link
Author

Ops =P disregard this one...
the modifications were working, but I edited the code directly instead of editing the tpl files =P
sorry fort that!
I have now fixed it, but I haven't committed yet, I am testing... later I am going to open another pull request, but then the package structure will be there... anyway.. tell me what you think!

Cheers

@vchahun
Copy link
Owner

vchahun commented Nov 28, 2012

Thanks Wilker for all these contributions!
I merged the simple changes, but I left the other algorithms for later when I have time to look at them...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants