Release #5
Merged
Release #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Last translation merge for possible continued v23.08 branch
- Fixed some existing issues in new aligned process. - Manually tested each external call scenario.
HTTP calling logic alignment
Used an "example.com" address so we're using a propoer reserved domain, and to avoid these trying to be delivered to the main bookstackapp domain. Closes BookStackApp#4518
- Changed use of array spread since it was not supported in PHP8.0. - Updated issue templates based to reduce less valueable fields, update some details, and try to help bug reports be more focused on bugs. - Updated readme with peertube link and attribution advistory for translations PRs.
Tested locally before & after change, and looked at code to compare. Nothing seen or experienced that should affect things, from testing all is working as expected with no difference from before. - Update composer requirement of socialite to that which included slack. - Updated PHP depds while there. - Updated format of socialite events to align with current documentation and to use class references instead of strings.
The page comments component would throw an error due to references to form elements/content, when form elements may not exist due to permisisons. For BookStackApp#4531
To allow for easier customization. Related to BookStackApp#4530
This adds specific handling for functions.php error loading to re-throw errors wrapped in a more descriptive message, to make it clear the error is due to an issue in their functions.php file. Decided to throw and stop, rather than ignore & continue, to be on the safe side in the event auth-level (or other security level) customizations have been made via functions.php. Adds test to cover. Closes BookStackApp#4504
- Updating formatting. - Tweaked truncation to roughly match elipsis char to width used. - Updated testing to use existing helpers, and ran check as admin user to avoid name conflicts.
Added test to cover. For BookStackApp#4543.
Would cause comment reply notifications to not be sent to expected user. Updated test to cover problem case. For BookStackApp#4548
- Updated sponsor text since it only mentioned GitHub, nothing else. - Updated translation contribution info to dissuade code-based contributions due to issues with conflicts/sync.
Also fixed text which could through deprecation notice due to not having a properly formed comment in use. For BookStackApp#4633
To allow hacking of all CodeMirror instances. Closes BookStackApp#4639.
- Updated anchor scroll change to open up details blocks if the target exists within. - Updated highlighting and animation implementation to fix hardly visible highlighting. - Removed old, now unused, handing of CM instances in details blocks. Related to BookStackApp#4637.
Change due to link color being more suitable in this case since it's not specifically a block with light text which is what app color is suited for. Specifically better for dark mode when a dark app color is used. For BookStackApp#4630
For BookStackApp#4649 More of a patch around the issue for now. Have opened BookStackApp#4656 to properly address.
Changes since adding notifications would cause direction to be assessed upon max height of 80vh, which caused large dropdowns like the audit log dropdown to drop up and/or go offscreen. This restores the default assessment of 500px, and adds dynamic max-height adjustment to provide more room for large dropdowns. For BookStackApp#4652
Updated image loading for intervention library to be via a specific 'initFromBinary' method to avoid being overly accepting of input types and mechansisms. For CVE-2023-6199
Also added content sniffing as an extra check. Added tests to cover.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.