Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: prometheus exporter for detailed metrics #16

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

feat: prometheus exporter for detailed metrics #16

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
68 changes: 39 additions & 29 deletions analyzer/analyze.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,23 +23,24 @@
import gzip
import itertools
import json
import logbook
import numpy
import pathlib
import re
import sys
import zipfile
from tqdm import tqdm
from inspect import signature

import logbook
import numpy
from tqdm import tqdm

logbook.StreamHandler(sys.stderr).push_application()
log = logbook.Logger("analyze")

from bokeh.embed import json_item
from bokeh.models import ColumnDataSource, TapTool, Span, Slope, ranges, LabelSet
from bokeh.models import ColumnDataSource, TapTool, Span, Slope, LabelSet
from bokeh.models.callbacks import CustomJS
from bokeh.palettes import Category20c, Category10, Colorblind
from bokeh.plotting import figure, output_file, save
from bokeh.plotting import figure


def groupby(keys, values, reducer):
Expand Down Expand Up @@ -571,14 +572,14 @@ def parse_table_name(scan_node):
else:
schema_name = handle.get("schemaName") # may be missing
table_name = handle.get("tableName") or handle.get("table")
if table_name is None and handle.get("id",None):
if table_name is None and handle.get("id", None):
# MemoryTableHandle doesn't contain its name in PrestoSQL 306+
table_name = "{}:{}".format(handle["@type"], handle["id"])
if isinstance(table_name, dict): # JMX may contain schema information here
schema_name = table_name["schema"]
table_name = table_name["table"]

connector_id = table.get("connectorId") or table.get("catalogHandle",None) or table.get("catalogName",None)
connector_id = table.get("connectorId") or table.get("catalogHandle", None) or table.get("catalogName", None)
values = [connector_id, schema_name, table_name]
values = [v for v in values if v is not None]
return ".".join(values)
Expand Down Expand Up @@ -1193,28 +1194,7 @@ def collect_metrics(stats):
}


def main():
p = argparse.ArgumentParser()
p.add_argument(
"-i",
"--input-file",
type=pathlib.Path,
help="Path to the extracted JSONL file (the output of extract.py)",
)
p.add_argument(
"-o",
"--output-file",
type=pathlib.Path,
default="./output.zip",
help="Path to the resulting zipped HTML report",
)
p.add_argument("-l", "--limit", type=int)
p.add_argument("--filter", type=str)
p.add_argument("--fail-on-error", action="store_true", default=False)
p.add_argument("--high-contrast-mode", action="store_true", default=False)
p.add_argument("-q", "--quiet", action="store_true", default=False)
args = p.parse_args()

def analyze(args):
log.info(
"loading {} = {:.3f} MB", args.input_file, args.input_file.stat().st_size / 1e6
)
Expand Down Expand Up @@ -1292,5 +1272,35 @@ def main():
raise ValueError("Unsupport output file extension: {}".format(args.output_file))


def get_args_parser():
p = argparse.ArgumentParser()
p.add_argument(
"-i",
"--input-file",
type=pathlib.Path,
help="Path to the extracted JSONL file (the output of extract.py)",
)
p.add_argument(
"-o",
"--output-file",
type=pathlib.Path,
default="./output.zip",
help="Path to the resulting zipped HTML report",
)
p.add_argument("-l", "--limit", type=int)
p.add_argument("--filter", type=str)
p.add_argument("--fail-on-error", action="store_true", default=False)
p.add_argument("--high-contrast-mode", action="store_true", default=False)
p.add_argument("-q", "--quiet", action="store_true", default=False)

return p


def main():
args = get_args_parser().parse_args()

analyze(args)


if __name__ == "__main__":
main()
55 changes: 41 additions & 14 deletions analyzer/collect.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,15 @@
import pathlib
import sys
import time
from datetime import datetime

import logbook
import requests
from requests.auth import HTTPBasicAuth

from extract import summary
from .analyze import query_datetime

logbook.StreamHandler(sys.stderr).push_application()
log = logbook.Logger("collect")

Expand Down Expand Up @@ -70,22 +75,16 @@ def str_to_bool(v):
return False


def main():
p = argparse.ArgumentParser()
p.add_argument("-c", "--coordinator", default="http://localhost:8080")
p.add_argument("-e", "--query-endpoint", default="/v1/query")
p.add_argument("-u", "--username")
p.add_argument("--username-request-header")
p.add_argument("-p", "--password")
p.add_argument("--certificate-verification", default=True, type=str_to_bool)
p.add_argument("-o", "--output-dir", default="JSONs", type=pathlib.Path)
p.add_argument("-d", "--delay", default=0.1, type=float)
p.add_argument("--loop", default=False, action="store_true")
p.add_argument("--loop-delay", type=float, default=1.0)
args = p.parse_args()
def collect(args):
args.output_dir.mkdir(parents=True, exist_ok=True)

client = Client(args.username, args.password, args.certificate_verification, args.username_request_header)
endpoint = "{}{}".format(args.coordinator, args.query_endpoint)
args.output_dir.mkdir(parents=True, exist_ok=True)

if args.only_new:
start_date = datetime.now()
else:
start_date = datetime.strptime('1900-01-01', '%Y-%m-%d')

done_state = {"FINISHED", "FAILED"}
while True:
Expand Down Expand Up @@ -116,11 +115,39 @@ def main():
with gzip.open(output_file.open("wb"), "wb") as f:
f.write(response.content)

if args.prometheus:
if query_datetime(query_id) >= start_date:
yield summary(response.json())

if args.loop:
time.sleep(args.loop_delay)
else:
break


def get_args_parser():
p = argparse.ArgumentParser()
group = p.add_argument_group('collect')

group.add_argument("-c", "--coordinator", default="http://localhost:8080")
group.add_argument("-e", "--query-endpoint", default="/v1/query")
group.add_argument("-u", "--username")
group.add_argument("--username-request-header")
group.add_argument("-p", "--password")
group.add_argument("--certificate-verification", default=True, type=str_to_bool)
group.add_argument("-o", "--output-dir", default="JSONs", type=pathlib.Path)
group.add_argument("-d", "--delay", default=0.1, type=float)
group.add_argument("--loop", default=False, action="store_true")
group.add_argument("--loop-delay", type=float, default=1.0)
group.add_argument("--only-new", default=False, action="store_true")
group.add_argument("--prometheus", default=False, action="store_true")

return p


def main():
collect(get_args_parser().parse_args())


if __name__ == "__main__":
main()
Loading