Update package for Sendable, and other cleanup #217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…imum Swift to 5.8, fixup docs and logo
…l, don't use benchmarker's DB for tests
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #217 +/- ##
==========================================
+ Coverage 63.12% 63.77% +0.64%
==========================================
Files 8 8
Lines 339 334 -5
==========================================
- Hits 214 213 -1
+ Misses 125 121 -4
|
0xTim
approved these changes
May 1, 2024
| @@ -81,7 +81,9 @@ extension DatabaseConfigurationFactory { | |||
| decodingContext: PostgresDecodingContext<some PostgresJSONDecoder>, | |||
| sqlLogLevel: Logger.Level = .debug | |||
| ) -> DatabaseConfigurationFactory { | |||
| .init { | |||
| let configuration = FakeSendable(wrappedValue: configuration) | |||
There was a problem hiding this comment.
Too much mutability. The correct solution is to do what was done in PostgresKit, deprecating the old one and making a completely new type, but that's more work than I'm willing to do this late in the lifetime of Fluent 4. This is more of a workaround for the lack of transferring; the configuration doesn't actually need to be Sendable conceptually.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes are now available in 2.9.0
Adds Sendable correctness and ExistentialAny compliance, bumps min Swift version to 5.8, leverages the new SQLKit functionality, removes
.error-level logging (uses.debuginstead), updates CI, modernizes README and docs.