Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update dependencies to fix vulnerability #240

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ffMathy
Copy link

@ffMathy ffMathy commented Oct 16, 2024

More info: https://nodejs.org/en/blog/npm/peer-dependencies

Right now, after the release of the Elastic NPM client version 8.15, they are now using different types. Because this dependency refers to another version, this then breaks and makes it impossible to provide the "client" option when constructing the log sink.

This fixes it, so that it is considered a peer dependency, thus allowing people to use their own version freely.

Should also lead to less maintenance of this package.

@ffMathy
Copy link
Author

ffMathy commented Oct 21, 2024

@vanthome if you are overburdened, I can help contribute to this project if you set me as repository contributor. I currently maintain a lot of open source projects, and it would be a pleasure to help out with this one too.

@ffMathy ffMathy changed the title fix: change elasticsearch dependency to a peer dependency fix: update dependencies to fix vulnerability Oct 22, 2024
@ffMathy
Copy link
Author

ffMathy commented Oct 22, 2024

@vanthome I also updated relevant other dependencies now. Can we get this out, as it fixes a security vulnerability? We are an enterprise user, so it is necessary for us.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants