Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Postgres backup task searching #48

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

lewislarsen
Copy link
Member

@lewislarsen lewislarsen commented Jan 10, 2025

Pull Request

Description

Using 'like' with postgres results in a pretty terrible searching experience due to it being case sensitive. This PR tweaks it for postgres connections.

In the future we should look into improving it for other connections too.

Additionally, also fixed the spacing issue when there's no results and conditionally hid the filter button like it was intended to be.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • Automated testing (Feature tests, Unit tests)
  • Manual testing

Checklist:

  • I have performed a self-review of my own code
  • My changes do not introduce any new warnings or errors
  • I have added tests that prove my fix is effective or that my feature works (where applicable)
  • New and existing tests pass locally with my changes
  • I have used translation helpers and provided translations (where applicable)
  • I have run code quality tools (e.g., linters) and addressed any issues

@lewislarsen lewislarsen merged commit 3e275e7 into vanguardbackup:main Jan 10, 2025
9 checks passed
@lewislarsen lewislarsen deleted the fix/task_search branch January 10, 2025 04:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant