WEB-3134 uber Carousel & other Cols Landing component changes #569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hout lots of visible overflow - fall back to simple spaced row, depending on item count vs items per view - ensure tabbable only if needed - allow for bulk carousel default initialising when some carousels may not contain ctrls - base templateWidth on parent el, since offsetWidth may be 0 for toggled hidden carousels - add parent template alignment with right-edge overflow
… for initially toggled hidden carousels
methodog
force-pushed
the
web-3134-uber-carousel-component
branch
2 times, most recently
from
175cb57 to
3b941a2
Compare
methodog
force-pushed
the
web-3134-uber-carousel-component
branch
from
3b941a2 to
579daa3
Compare
…n conflicts and fix safari; maintain focus on Ctrls; fully trap click on items out of view; simplify template fitting/alignment; improve markup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tycho tied to
Includes merge of WEB-3133